Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WGSL] Rename ArgumentBuffer roles to BindGroup #9390

Merged
merged 1 commit into from
Feb 1, 2023
Merged

[WGSL] Rename ArgumentBuffer roles to BindGroup #9390

merged 1 commit into from
Feb 1, 2023

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented Jan 31, 2023 •
edited by webkit-early-warning-system

ec8c0fe

[WGSL] Rename `ArgumentBuffer` roles to `BindGroup`
https://bugs.webkit.org/show_bug.cgi?id=251443
rdar://104873689

Reviewed by Myles C. Maxfield.

Let's try use the WGSL nomenclature instead of Metal in parts of the
codebase that aren't Metal-specific (whenever possible)

* Source/WebGPU/WGSL/AST/ASTFunctionDecl.h:
* Source/WebGPU/WGSL/AST/ASTStructureDecl.h:
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):
(WGSL::RewriteGlobalVariables::insertParameters):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/259670@main

6e1328e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
  🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo self-assigned this Jan 31, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Jan 31, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash d2b69f6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

litherum
litherum approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@litherum litherum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tadeuzagallo tadeuzagallo force-pushed the eng/WGSL-Rename-ArgumentBuffer-roles-to-BindGroup branch from d2b69f6 to 64cec0b Compare February 1, 2023 07:20
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 64cec0b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac   🛠 wpe ⏳ 🛠 🧪 win
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ⏳ 🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ❌ 🛠 tv ❌ 🧪 mac-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 watch ❌ 🧪 mac-wk2-stress
⏳ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 1, 2023
@tadeuzagallo tadeuzagallo force-pushed the eng/WGSL-Rename-ArgumentBuffer-roles-to-BindGroup branch from 64cec0b to 6e1328e Compare February 1, 2023 07:24
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 6e1328e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
  🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 1, 2023
@tadeuzagallo
[WGSL] Rename ArgumentBuffer roles to BindGroup
ec8c0fe 
https://bugs.webkit.org/show_bug.cgi?id=251443
rdar://104873689

Reviewed by Myles C. Maxfield.

Let's try use the WGSL nomenclature instead of Metal in parts of the
codebase that aren't Metal-specific (whenever possible)

* Source/WebGPU/WGSL/AST/ASTFunctionDecl.h:
* Source/WebGPU/WGSL/AST/ASTStructureDecl.h:
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):
(WGSL::RewriteGlobalVariables::insertParameters):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/259670@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/WGSL-Rename-ArgumentBuffer-roles-to-BindGroup branch from 6e1328e to ec8c0fe Compare February 1, 2023 09:58
@webkit-commit-queue
Copy link
Collaborator

Committed 259670@main (ec8c0fe): https://commits.webkit.org/259670@main

Reviewed commits have been landed. Closing PR #9390 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit ec8c0fe into WebKit:main Feb 1, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 1, 2023
@tadeuzagallo tadeuzagallo deleted the eng/WGSL-Rename-ArgumentBuffer-roles-to-BindGroup branch May 17, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litherum litherum litherum approved these changes

@mwyrzykowski mwyrzykowski mwyrzykowski approved these changes

@djg djg Awaiting requested review from djg djg is a code owner

Assignees

@tadeuzagallo tadeuzagallo

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
6 participants
@tadeuzagallo @webkit-early-warning-system @webkit-commit-queue @litherum @mwyrzykowski @webkit-ews-buildbot