Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer] Missing chain-ups to parent class constructed in custom GStreamer elements #9392

Merged
merged 1 commit into from
Feb 1, 2023
Merged

[GStreamer] Missing chain-ups to parent class constructed in custom GStreamer elements #9392

merged 1 commit into from
Feb 1, 2023

Conversation

philn
Copy link
Member

@philn philn commented Jan 31, 2023 •
edited by webkit-early-warning-system

ad178f9

[GStreamer] Missing chain-ups to parent class constructed in custom GStreamer elements
https://bugs.webkit.org/show_bug.cgi?id=251446

Reviewed by Xabier Rodriguez-Calvar.

* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
* Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkConstructed):
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderConstructed):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp:
(webkitFliteSrcConstructed):

Canonical link: https://commits.webkit.org/259672@main

fb8e93c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@philn philn self-assigned this Jan 31, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jan 31, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash e1a9973)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
⏳ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@philn philn requested a review from calvaris January 31, 2023 19:00
@philn philn changed the title [GStreamer] Missing chain-up to parent class constructed vfunc [GStreamer] VideoEncoder: Missing chain-up to parent class constructed vfunc Jan 31, 2023
@philn philn changed the title [GStreamer] VideoEncoder: Missing chain-up to parent class constructed vfunc [GStreamer] Missing chain-ups to parent class constructed in custom GStreamer elements Jan 31, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash fb8e93c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 1, 2023
@philn philn added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 1, 2023
@philn
[GStreamer] Missing chain-ups to parent class constructed in custom G…
ad178f9 
…Streamer elements

https://bugs.webkit.org/show_bug.cgi?id=251446

Reviewed by Xabier Rodriguez-Calvar.

* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
* Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkConstructed):
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderConstructed):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp:
(webkitFliteSrcConstructed):

Canonical link: https://commits.webkit.org/259672@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259672@main (ad178f9): https://commits.webkit.org/259672@main

Reviewed commits have been landed. Closing PR #9392 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit ad178f9 into WebKit:main Feb 1, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 1, 2023
@philn philn deleted the eng/251446 branch February 1, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvaris calvaris calvaris approved these changes

Assignees

@philn philn

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
5 participants
@philn @webkit-early-warning-system @webkit-commit-queue @calvaris @webkit-ews-buildbot