Use CheckedPtr in CounterNode #9397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
the
Layout and Rendering
|
EWS run on current version of this PR (hash d5a7ea2)
|
rniwa
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=251447 Reviewed by Alan Baradlay. Deployed CheckedPtr in CounterNode in place of raw pointers. * Source/WebCore/rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::nextInPreOrderAfterChildren const): (WebCore::CounterNode::nextInPreOrder const): (WebCore::CounterNode::lastDescendant const): (WebCore::CounterNode::previousInPreOrder const): (WebCore::CounterNode::resetThisAndDescendantsRenderers): (WebCore::CounterNode::recount): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): * Source/WebCore/rendering/CounterNode.h: (WebCore::CounterNode::parent const): (WebCore::CounterNode::previousSibling const): (WebCore::CounterNode::nextSibling const): (WebCore::CounterNode::firstChild const): (WebCore::CounterNode::lastChild const): * Source/WebCore/rendering/RenderCounter.cpp: (WebCore::makeCounterNode): (WebCore::RenderCounter::originalText const): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): (showCounterRendererTree): * Source/WebCore/rendering/RenderCounter.h: Canonical link: https://commits.webkit.org/259659@main
webkit-early-warning-system
force-pushed
the
fix251447
branch
from
d5a7ea2
to
c5914bd
Compare
|
Committed 259659@main (c5914bd): https://commits.webkit.org/259659@main Reviewed commits have been landed. Closing PR #9397 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c5914bd
d5a7ea2
🛠 🧪 win🛠 wincairo🧪 api-gtk🧪 mac-AS-debug-wk2