Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix the SVGAnimationElement range setting methods with "set" instead of "calculate" #9401

Conversation

shallawa
Copy link
Contributor

@shallawa shallawa commented Jan 31, 2023

dd0930c

Prefix the SVGAnimationElement range setting methods with "set" instead of "calculate"
https://bugs.webkit.org/show_bug.cgi?id=251450
rdar://104881126

Reviewed by Nikolas Zimmermann.

This will make the code more readable and the names of these methods will match
the names of the SVGAttributeAnimator methods which are called by these methods.

* Source/WebCore/svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::setFromAndToValues):
(WebCore::SVGAnimateElementBase::setFromAndByValues):
(WebCore::SVGAnimateElementBase::setToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateElementBase::calculateFromAndByValues): Deleted.
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue): Deleted.
* Source/WebCore/svg/SVGAnimateElementBase.h:
* Source/WebCore/svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::setFromAndToValues):
(WebCore::SVGAnimateMotionElement::setFromAndByValues):
(WebCore::SVGAnimateMotionElement::setToAtEndOfDurationValue):
(WebCore::SVGAnimateMotionElement::calculateToAtEndOfDurationValue): Deleted.
(WebCore::SVGAnimateMotionElement::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues): Deleted.
* Source/WebCore/svg/SVGAnimateMotionElement.h:
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
(WebCore::SVGAnimationElement::updateAnimation):
* Source/WebCore/svg/SVGAnimationElement.h:

Canonical link: https://commits.webkit.org/259705@main

4a93aa6

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk   πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@shallawa shallawa self-assigned this Jan 31, 2023
@shallawa shallawa added the SVG For bugs in the SVG implementation. label Jan 31, 2023
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@shallawa shallawa added the merge-queue Applied to send a pull request to merge-queue label Feb 1, 2023
…ad of "calculate"

https://bugs.webkit.org/show_bug.cgi?id=251450
rdar://104881126

Reviewed by Nikolas Zimmermann.

This will make the code more readable and the names of these methods will match
the names of the SVGAttributeAnimator methods which are called by these methods.

* Source/WebCore/svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::setFromAndToValues):
(WebCore::SVGAnimateElementBase::setFromAndByValues):
(WebCore::SVGAnimateElementBase::setToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateElementBase::calculateFromAndByValues): Deleted.
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue): Deleted.
* Source/WebCore/svg/SVGAnimateElementBase.h:
* Source/WebCore/svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::setFromAndToValues):
(WebCore::SVGAnimateMotionElement::setFromAndByValues):
(WebCore::SVGAnimateMotionElement::setToAtEndOfDurationValue):
(WebCore::SVGAnimateMotionElement::calculateToAtEndOfDurationValue): Deleted.
(WebCore::SVGAnimateMotionElement::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues): Deleted.
* Source/WebCore/svg/SVGAnimateMotionElement.h:
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
(WebCore::SVGAnimationElement::updateAnimation):
* Source/WebCore/svg/SVGAnimationElement.h:

Canonical link: https://commits.webkit.org/259705@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Prefix-the-SVGAnimationElement-range-setting-methods-with-set-instead-of-calculate branch from 4a93aa6 to dd0930c Compare February 1, 2023 19:39
@webkit-commit-queue
Copy link
Collaborator

Committed 259705@main (dd0930c): https://commits.webkit.org/259705@main

Reviewed commits have been landed. Closing PR #9401 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dd0930c into WebKit:main Feb 1, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 1, 2023
@shallawa shallawa deleted the eng/Prefix-the-SVGAnimationElement-range-setting-methods-with-set-instead-of-calculate branch May 9, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SVG For bugs in the SVG implementation.
Projects
None yet
4 participants