[WebGPU] Connect PresentationContext and CompositorIntegration #9428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 96cf08d)
|
mwyrzykowski
approved these changes
Feb 1, 2023
tadeuzagallo
approved these changes
Feb 1, 2023
webkit-early-warning-system
force-pushed
the
eng/WebGPU-Connect-PresentationContext-and-CompositorIntegration
branch
from
96cf08d
to
d492b33
Compare
https://bugs.webkit.org/show_bug.cgi?id=251479 rdar://104900104 Reviewed by Tadeu Zagallo. A PresentationContext is created with a PresentationContextDescriptor, which previously had 0 fields. This patch just adds a CompositorIntegration& as a field, so PresentationContexts are now created with a CompositorIntegration. This patch doesn't actually have the PresentationContext do anything with the CompositorIntegration; it just adds the field in the descriptor. The next patch will make the two actually use each other. * Source/WebCore/Modules/WebGPU/GPU.cpp: (WebCore::GPU::createCompositorIntegration): * Source/WebCore/Modules/WebGPU/GPU.h: * Source/WebCore/Modules/WebGPU/GPUPresentationContextDescriptor.h: (WebCore::GPUPresentationContextDescriptor::convertToBacking const): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp: (PAL::WebGPU::GPUImpl::createPresentationContext): (PAL::WebGPU::GPUImpl::createCompositorIntegration): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.h: * Source/WebCore/PAL/pal/graphics/WebGPU/WebGPU.h: * Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPresentationContextDescriptor.h: * Source/WebCore/html/canvas/GPUCanvasContextCocoa.cpp: (WebCore::presentationContextDescriptor): (WebCore::GPUCanvasContextCocoa::GPUCanvasContextCocoa): (WebCore::GPUCanvasContextCocoa::prepareForDisplay): * Source/WebCore/html/canvas/GPUCanvasContextCocoa.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp: (WebKit::RemoteGPU::createCompositorIntegration): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.messages.in: * Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.h: * Source/WebKit/Shared/WebGPU/WebGPUPresentationContextDescriptor.serialization.in: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp: (WebKit::RemoteGPUProxy::createCompositorIntegration): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h: Canonical link: https://commits.webkit.org/259669@main
webkit-early-warning-system
force-pushed
the
eng/WebGPU-Connect-PresentationContext-and-CompositorIntegration
branch
from
d492b33
to
87e3bf7
Compare
|
Committed 259669@main (87e3bf7): https://commits.webkit.org/259669@main Reviewed commits have been landed. Closing PR #9428 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
litherum
deleted the
eng/WebGPU-Connect-PresentationContext-and-CompositorIntegration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
87e3bf7
96cf08d
🛠 🧪 win🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-gtk🛠 tv-sim🧪 mac-AS-debug-wk2