-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WGSL] Keep expression enums in sync with printed representation #9432
[WGSL] Keep expression enums in sync with printed representation #9432
Conversation
EWS run on previous version of this PR (hash 47900d9) |
It's is possible to quieten the style check about the use of a macro inside an enum? |
I don't think so, but I wouldn't worry about it. Looks like the commit title got messed up somehow. |
47900d9
to
13528b3
Compare
EWS run on previous version of this PR (hash 13528b3) |
13528b3
to
26884b6
Compare
EWS run on current version of this PR (hash 26884b6) |
https://bugs.webkit.org/show_bug.cgi?id=251484 rdar://problem/104902431 Reviewed by Myles C. Maxfield. Use preprocess fruit lists to keep the enum definition and string representation of binary and unary expression operations in sync. * Source/WebGPU/WGSL/AST/ASTBinaryExpression.cpp: (WGSL::AST::toString): (WGSL::AST::printInternal): Deleted. * Source/WebGPU/WGSL/AST/ASTBinaryExpression.h: (WGSL::AST::toASCIILiteral): * Source/WebGPU/WGSL/AST/ASTUnaryExpression.cpp: (WGSL::AST::printInternal): * Source/WebGPU/WGSL/AST/ASTUnaryExpression.h: (WGSL::AST::toASCIILiteral): Canonical link: https://commits.webkit.org/260290@main
26884b6
to
6bc04af
Compare
Committed 260290@main (6bc04af): https://commits.webkit.org/260290@main Reviewed commits have been landed. Closing PR #9432 and removing active labels. |
6bc04af
26884b6
π wincairoπ§ͺ ios-wk2π§ͺ gtk-wk2π§ͺ api-gtk