Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setUsernameForLocalCredentialWithGroupAndID SPI #945

Merged
merged 0 commits into from May 31, 2022
Merged

Remove setUsernameForLocalCredentialWithGroupAndID SPI #945

merged 0 commits into from May 31, 2022

Conversation

pascoej
Copy link
Member

@pascoej pascoej commented May 23, 2022 •
edited by webkit-early-warning-system

c13c9ba

Remove setUsernameForLocalCredentialWithGroupAndID SPI
https://bugs.webkit.org/show_bug.cgi?id=240829
<rdar://93366441 >

Reviewed by Brent Fulgham.

This SPI is no longer used internally and can be removed.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]): Deleted.
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithGroupAndID:credential:username:]): Deleted.

Canonical link: https://commits.webkit.org/251159@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@pascoej pascoej self-assigned this May 23, 2022
@pascoej pascoej added WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). WebKit Nightly Build labels May 23, 2022
@pascoej pascoej requested a review from brentfulgham May 25, 2022 16:45
brentfulgham
brentfulgham approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted code is safe code! r=me

@pascoej pascoej added the merge-queue Applied to send a pull request to merge-queue label May 31, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Remove-setUsernameForLocalCredentialWithGroupAndID-SPI branch from db9d34d to c13c9ba Compare May 31, 2022 21:14
@webkit-early-warning-system webkit-early-warning-system merged commit c13c9ba into WebKit:main May 31, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295064 (251159@main): https://commits.webkit.org/251159@main

Reviewed commits have been landed. Closing PR #945 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

Assignees

@pascoej pascoej

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
3 participants
@pascoej @webkit-early-warning-system @brentfulgham