[fetch] Implement `Headers.prototype.getSetCookie`. #9490

andreubotella · 2023-02-01T23:41:14Z

`77fd8de`

[fetch] Implement `Headers.prototype.getSetCookie`.
https://bugs.webkit.org/show_bug.cgi?id=251194

Reviewed by Youenn Fablet.

This change implements the `getSetCookie` method of the fetch spec's
`Headers` interface. This change allows storing `Set-Cookie` headers as
a list of values, and retrieving the separate values, rather than their
combined representation, which is ambiguous. This change also makes it
so iterating through `Headers` objects will yield `Set-Cookie` headers
separately rather than combined, which is part of the same change in the
fetch spec.

Given that `Set-Cookie` is a forbidden header name in both requests and
responses, this will not be useful for any uses of `Headers` related to
fetch. It does allows some non-fetch use cases, however, and enables
further compatibility with server-side runtimes that do allow this
header.

Rather than refactoring `HTTPHeaderMap` to not combine (all) headers,
this implementation makes use of the fact that `Set-Cookie` is forbidden
for both requests and responses, to store the `Set-Cookie` values in a
vector of strings directly in `FetchHeaders` instead. This needed such
header name to be special-cased in almost every operation of this class.
And in order to have `Set-Cookie` headers properly appear in their right
order in the pair iterator, `m_keys` has been changed to be a pair where
the second element is an index into the `Set-Cookie` values vector,
which is ignored for other header names.

Fetch spec PR: whatwg/fetch#1346

This commit also imports the corresponding WPT tests from
web-platform-tests/wpt#31442, and adds some
additional tests.

* Source/WebCore/Modules/fetch/FetchHeaders.cpp:
(WebCore::appendToHeaderMap):
(WebCore::fillHeaderMap):
(WebCore::FetchHeaders::create):
(WebCore::FetchHeaders::fill):
(WebCore::FetchHeaders::append):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::get const):
(WebCore::FetchHeaders::getSetCookie const):
(WebCore::FetchHeaders::has const):
(WebCore::FetchHeaders::set):
(WebCore::FetchHeaders::Iterator::next):
* Source/WebCore/Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::create):
(WebCore::FetchHeaders::fastGet const):
(WebCore::FetchHeaders::fastHas const):
(WebCore::FetchHeaders::fastSet):
(WebCore::FetchHeaders::FetchHeaders):
* Source/WebCore/Modules/fetch/FetchHeaders.idl:
* Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::httpHeaderField const):

Canonical link: https://commits.webkit.org/260533@main

c6b5177

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-01T23:42:32Z

EWS run on previous version of this PR (hash 44b6fee)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
~~🧪 bindings~~	~~🛠 ios-sim~~	⏳ 🛠 mac-AS-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	⏳ 🧪 mac-wk1	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch-sim

andreubotella · 2023-02-01T23:43:23Z

I didn't add tests because there is a WPT PR (web-platform-tests/wpt#31442) that hasn't been merged yet. Or should I add that test to this PR for now, to run it under CI?

I would appreciate comments on the iterator changes and on the fast methods.

I also need to document this to some degree.

webkit-early-warning-system · 2023-02-01T23:52:01Z

EWS run on previous version of this PR (hash fda8054)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

youennf

Some suggestions below.
This patch needs tests, ideally WPT tests.

Source/WebCore/Modules/fetch/FetchHeaders.cpp

Source/WebCore/Modules/fetch/FetchHeaders.h

Source/WebCore/Modules/fetch/FetchHeaders.cpp

webkit-early-warning-system · 2023-02-02T19:42:26Z

EWS run on previous version of this PR (hash 3fe363b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

andreubotella · 2023-02-02T20:03:00Z

Some suggestions below. This patch needs tests, ideally WPT tests.

About WPT, there's a PR at web-platform-tests/wpt#31442. I just pushed a few additional tests there, including one for iteration invalidation.

webkit-early-warning-system · 2023-02-08T10:32:09Z

EWS run on previous version of this PR (hash 8c11cca)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	⏳ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk2~~
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

andreubotella · 2023-02-08T10:38:15Z

Sorry for the PR rename churn, this is my first time working with Webkit's Github workflow, and I didn't realize git-webkit pr treated multiple commits as a stack of changes.

Anyway, the WPT PR has now been merged (as well as the spec PR), and I've updated this PR to include those tests.

webkit-early-warning-system · 2023-02-08T10:40:09Z

EWS run on previous version of this PR (hash 5db5b93)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 wincairo
⏳ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 mac-wk1	⏳ 🧪 api-gtk
	~~🛠 tv~~	⏳ 🧪 mac-wk2
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	⏳ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-08T10:43:26Z

EWS run on previous version of this PR (hash 1754f2d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

Source/WebCore/Modules/fetch/FetchHeaders.cpp

LayoutTests/imported/w3c/resources/import-expectations.json

webkit-early-warning-system · 2023-02-08T13:44:56Z

EWS run on previous version of this PR (hash b0beebe)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-09T09:14:04Z

EWS run on previous version of this PR (hash 5590d0a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-09T18:13:34Z

EWS run on previous version of this PR (hash 1ebee5c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	~~🧪 mac-wk2~~	⏳ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

youennf · 2023-02-09T18:51:36Z

Source/WebCore/Modules/fetch/FetchHeaders.cpp

+
+    if (equalIgnoringASCIICase(name, "Set-Cookie"_str)) {
+        if (m_setCookieValues.isEmpty())
+            return String();


We probably do not need to optimize this case.

This is just about the size-0 case, right? The size-1 optimization can stay.

Oh, I hadn't realized that returning String() on the size-0 case isn't an optimization, since get() must return null. The size-1 case is an optimization, but not apparently one that would achieve anything, since it seems like StringBuilder directly uses the passed string in this case.

I'm therefore keeping the size-0 case and removing the size-1 case.

Source/WebCore/Modules/fetch/FetchHeaders.cpp

youennf · 2023-02-09T19:12:13Z

Looks almost ready to me, some nits below.
If you made some WPT test changes, please put up a WPT PR for it.

webkit-early-warning-system · 2023-02-09T19:54:44Z

EWS run on previous version of this PR (hash 65dd602)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

andreubotella · 2023-02-09T21:07:43Z

Looks almost ready to me, some nits below. If you made some WPT test changes, please put up a WPT PR for it.

I opened web-platform-tests/wpt#38437

webkit-early-warning-system · 2023-02-10T19:59:32Z

EWS run on previous version of this PR (hash c0d625c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-14T22:20:08Z

EWS run on previous version of this PR (hash 587388e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

andreubotella · 2023-02-19T23:01:14Z

@youennf PTAL

youennf

LGTM

Source/WebCore/Modules/fetch/FetchHeaders.cpp

webkit-early-warning-system · 2023-02-20T11:11:02Z

EWS run on current version of this PR (hash c6b5177)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=251194 Reviewed by Youenn Fablet. This change implements the `getSetCookie` method of the fetch spec's `Headers` interface. This change allows storing `Set-Cookie` headers as a list of values, and retrieving the separate values, rather than their combined representation, which is ambiguous. This change also makes it so iterating through `Headers` objects will yield `Set-Cookie` headers separately rather than combined, which is part of the same change in the fetch spec. Given that `Set-Cookie` is a forbidden header name in both requests and responses, this will not be useful for any uses of `Headers` related to fetch. It does allows some non-fetch use cases, however, and enables further compatibility with server-side runtimes that do allow this header. Rather than refactoring `HTTPHeaderMap` to not combine (all) headers, this implementation makes use of the fact that `Set-Cookie` is forbidden for both requests and responses, to store the `Set-Cookie` values in a vector of strings directly in `FetchHeaders` instead. This needed such header name to be special-cased in almost every operation of this class. And in order to have `Set-Cookie` headers properly appear in their right order in the pair iterator, `m_keys` has been changed to be a pair where the second element is an index into the `Set-Cookie` values vector, which is ignored for other header names. Fetch spec PR: whatwg/fetch#1346 This commit also imports the corresponding WPT tests from web-platform-tests/wpt#31442, and adds some additional tests. * Source/WebCore/Modules/fetch/FetchHeaders.cpp: (WebCore::appendToHeaderMap): (WebCore::fillHeaderMap): (WebCore::FetchHeaders::create): (WebCore::FetchHeaders::fill): (WebCore::FetchHeaders::append): (WebCore::FetchHeaders::remove): (WebCore::FetchHeaders::get const): (WebCore::FetchHeaders::getSetCookie const): (WebCore::FetchHeaders::has const): (WebCore::FetchHeaders::set): (WebCore::FetchHeaders::Iterator::next): * Source/WebCore/Modules/fetch/FetchHeaders.h: (WebCore::FetchHeaders::create): (WebCore::FetchHeaders::fastGet const): (WebCore::FetchHeaders::fastHas const): (WebCore::FetchHeaders::fastSet): (WebCore::FetchHeaders::FetchHeaders): * Source/WebCore/Modules/fetch/FetchHeaders.idl: * Source/WebCore/platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::httpHeaderField const): Canonical link: https://commits.webkit.org/260533@main

webkit-commit-queue · 2023-02-20T12:41:41Z

Committed 260533@main (77fd8de): https://commits.webkit.org/260533@main

Reviewed commits have been landed. Closing PR #9490 and removing active labels.

youennf reviewed Feb 2, 2023

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 3, 2023

andreubotella force-pushed the getSetCookie branch from 3fe363b to 8c11cca Compare February 8, 2023 10:31

andreubotella changed the title ~~[fetch] Implement Headers.prototype.getSetCookie.~~ Add WPT tests Feb 8, 2023

andreubotella changed the title ~~Add WPT tests~~ [fetch] Implement Headers.prototype.getSetCookie Feb 8, 2023

andreubotella force-pushed the getSetCookie branch from 8c11cca to 5db5b93 Compare February 8, 2023 10:35

andreubotella changed the title ~~[fetch] Implement Headers.prototype.getSetCookie~~ [fetch] Implement Headers.prototype.getSetCookie. Feb 8, 2023

andreubotella force-pushed the getSetCookie branch from 5db5b93 to 1754f2d Compare February 8, 2023 10:41

youennf reviewed Feb 8, 2023

View reviewed changes

andreubotella force-pushed the getSetCookie branch from 1754f2d to b0beebe Compare February 8, 2023 13:44

andreubotella force-pushed the getSetCookie branch from b0beebe to 5590d0a Compare February 9, 2023 09:07

andreubotella force-pushed the getSetCookie branch from 5590d0a to 1ebee5c Compare February 9, 2023 18:12

andreubotella requested a review from youennf February 9, 2023 18:12

youennf reviewed Feb 9, 2023

View reviewed changes

andreubotella force-pushed the getSetCookie branch from 1ebee5c to 65dd602 Compare February 9, 2023 19:54

andreubotella force-pushed the getSetCookie branch from 65dd602 to c0d625c Compare February 10, 2023 19:59

andreubotella force-pushed the getSetCookie branch from c0d625c to 587388e Compare February 14, 2023 22:11

andreubotella requested a review from youennf February 14, 2023 22:12

youennf approved these changes Feb 20, 2023

View reviewed changes

Source/WebCore/Modules/fetch/FetchHeaders.cpp Outdated Show resolved Hide resolved

andreubotella force-pushed the getSetCookie branch from 587388e to c6b5177 Compare February 20, 2023 11:10

youennf added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 20, 2023

webkit-early-warning-system force-pushed the getSetCookie branch from c6b5177 to 77fd8de Compare February 20, 2023 12:41

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 20, 2023

webkit-early-warning-system merged commit 77fd8de into WebKit:main Feb 20, 2023

andreubotella deleted the getSetCookie branch February 20, 2023 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fetch] Implement `Headers.prototype.getSetCookie`. #9490

[fetch] Implement `Headers.prototype.getSetCookie`. #9490

andreubotella commented Feb 1, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 1, 2023 •

edited

andreubotella commented Feb 1, 2023 •

edited

webkit-early-warning-system commented Feb 1, 2023 •

edited

youennf left a comment

webkit-early-warning-system commented Feb 2, 2023 •

edited

andreubotella commented Feb 2, 2023

webkit-early-warning-system commented Feb 8, 2023 •

edited

andreubotella commented Feb 8, 2023

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 9, 2023 •

edited

webkit-early-warning-system commented Feb 9, 2023 •

edited

youennf Feb 9, 2023

andreubotella Feb 9, 2023

andreubotella Feb 10, 2023

youennf commented Feb 9, 2023

webkit-early-warning-system commented Feb 9, 2023 •

edited

andreubotella commented Feb 9, 2023

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 14, 2023 •

edited

andreubotella commented Feb 19, 2023

youennf left a comment

webkit-early-warning-system commented Feb 20, 2023 •

edited

webkit-commit-queue commented Feb 20, 2023

[fetch] Implement Headers.prototype.getSetCookie. #9490

[fetch] Implement Headers.prototype.getSetCookie. #9490

Conversation

andreubotella commented Feb 1, 2023 • edited by webkit-early-warning-system

77fd8de

webkit-early-warning-system commented Feb 1, 2023 • edited

andreubotella commented Feb 1, 2023 • edited

webkit-early-warning-system commented Feb 1, 2023 • edited

youennf left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 2, 2023 • edited

andreubotella commented Feb 2, 2023

webkit-early-warning-system commented Feb 8, 2023 • edited

andreubotella commented Feb 8, 2023

webkit-early-warning-system commented Feb 8, 2023 • edited

webkit-early-warning-system commented Feb 8, 2023 • edited

webkit-early-warning-system commented Feb 8, 2023 • edited

webkit-early-warning-system commented Feb 9, 2023 • edited

webkit-early-warning-system commented Feb 9, 2023 • edited

youennf Feb 9, 2023

Choose a reason for hiding this comment

andreubotella Feb 9, 2023

Choose a reason for hiding this comment

andreubotella Feb 10, 2023

Choose a reason for hiding this comment

youennf commented Feb 9, 2023

webkit-early-warning-system commented Feb 9, 2023 • edited

andreubotella commented Feb 9, 2023

webkit-early-warning-system commented Feb 10, 2023 • edited

webkit-early-warning-system commented Feb 14, 2023 • edited

andreubotella commented Feb 19, 2023

youennf left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 20, 2023 • edited

webkit-commit-queue commented Feb 20, 2023

[fetch] Implement `Headers.prototype.getSetCookie`. #9490

[fetch] Implement `Headers.prototype.getSetCookie`. #9490

andreubotella commented Feb 1, 2023 •

edited by webkit-early-warning-system

`77fd8de`

webkit-early-warning-system commented Feb 1, 2023 •

edited

andreubotella commented Feb 1, 2023 •

edited

webkit-early-warning-system commented Feb 1, 2023 •

edited

webkit-early-warning-system commented Feb 2, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 9, 2023 •

edited

webkit-early-warning-system commented Feb 9, 2023 •

edited

webkit-early-warning-system commented Feb 9, 2023 •

edited

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 14, 2023 •

edited

webkit-early-warning-system commented Feb 20, 2023 •

edited