Relax the checks of the alpha channel of the blurred stroke in fast/canvas/canvas-scale-strokePath-shadow.html #9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 17eab40)
|
grorg
approved these changes
Feb 2, 2023
…anvas/canvas-scale-strokePath-shadow.html https://bugs.webkit.org/show_bug.cgi?id=251558 rdar://104761905 Reviewed by Dean Jackson. Relax the check for the alpha channel of the blurred stroke in this test to avoid rebase-line the expectation in the future. And git rid of the platform expectation. Ensure the alpha channel of the blurred stroke is between 75 and 225 instead of 175 and 225. * LayoutTests/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: * LayoutTests/fast/canvas/canvas-scale-strokePath-shadow.html: * LayoutTests/platform/ios/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed. * LayoutTests/platform/mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed. * LayoutTests/platform/win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed. Canonical link: https://commits.webkit.org/259765@main
webkit-early-warning-system
force-pushed
the
eng/Relax-the-checks-of-the-alpha-channel-of-the-blurred-stroke-in-fastcanvascanvas-scale-strokePath-shadow-html
branch
from
17eab40
to
d538ed7
Compare
|
Committed 259765@main (d538ed7): https://commits.webkit.org/259765@main Reviewed commits have been landed. Closing PR #9491 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
shallawa
deleted the
eng/Relax-the-checks-of-the-alpha-channel-of-the-blurred-stroke-in-fastcanvascanvas-scale-strokePath-shadow-html
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d538ed7
17eab40