New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPE] Switch to use always complex text code path #9513
[WPE] Switch to use always complex text code path #9513
Conversation
EWS run on current version of this PR (hash 4242a24) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the changes outside of the LayoutTests directory? The interface doesn't load beyond 3000 files, and the changelog doesn't list them (while it's fine to avoid listing the changed baselines).
The only change in the source code is removing
|
Here's the diff: diff --git a/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp b/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
index 3bddcfc5d875..a9a3531a1b9b 100644
--- a/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
+++ b/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
@@ -60,9 +60,8 @@ namespace WebKit {
void WebProcessPool::platformInitialize()
{
-#if PLATFORM(GTK)
m_alwaysUsesComplexTextCodePath = true;
-#endif
+
if (const char* forceComplexText = getenv("WEBKIT_FORCE_COMPLEX_TEXT")) |
I think we don't need the environment variable or the platform-specific implementation code anymore. |
The env var is still useful for debugging. |
https://bugs.webkit.org/show_bug.cgi?id=251579 Reviewed by Carlos Garcia Campos. It's been a default on GTK since `https://commits.webkit.org/200076@main`. It fixes a lot of WPE tests and lets us reuse already existing baselines for passing GTK tests. Canonical link: https://commits.webkit.org/259842@main
4242a24
to
c92522e
Compare
Committed 259842@main (c92522e): https://commits.webkit.org/259842@main Reviewed commits have been landed. Closing PR #9513 and removing active labels. |
c92522e
4242a24