Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPE] Switch to use always complex text code path #9513

Conversation

@obyknovenius obyknovenius self-assigned this Feb 2, 2023
@obyknovenius obyknovenius added the WPE WebKit WebKit WPE component label Feb 2, 2023
@obyknovenius obyknovenius added the request-merge-queue Request a pull request to be added to merge-queue once ready label Feb 2, 2023
@zdobersek zdobersek self-requested a review February 2, 2023 15:18
Copy link
Contributor

@zdobersek zdobersek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the changes outside of the LayoutTests directory? The interface doesn't load beyond 3000 files, and the changelog doesn't list them (while it's fine to avoid listing the changed baselines).

@obyknovenius
Copy link
Contributor Author

The only change in the source code is removing #if PLATFORM(GTK) in WebProcessPoolGLib.cpp:

@obyknovenius
Copy link
Contributor Author

Here's the diff:

diff --git a/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp b/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
index 3bddcfc5d875..a9a3531a1b9b 100644
--- a/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
+++ b/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
@@ -60,9 +60,8 @@ namespace WebKit {
 
 void WebProcessPool::platformInitialize()
 {
-#if PLATFORM(GTK)
     m_alwaysUsesComplexTextCodePath = true;
-#endif
+
     if (const char* forceComplexText = getenv("WEBKIT_FORCE_COMPLEX_TEXT"))

@mcatanzaro
Copy link
Contributor

I think we don't need the environment variable or the platform-specific implementation code anymore.

@carlosgcampos
Copy link
Contributor

The env var is still useful for debugging.

@aperezdc aperezdc added the merge-queue Applied to send a pull request to merge-queue label Feb 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=251579

Reviewed by Carlos Garcia Campos.

It's been a default on GTK since `https://commits.webkit.org/200076@main`.
It fixes a lot of WPE tests and lets us reuse already existing baselines
for passing GTK tests.

Canonical link: https://commits.webkit.org/259842@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259842@main (c92522e): https://commits.webkit.org/259842@main

Reviewed commits have been landed. Closing PR #9513 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit c92522e into WebKit:main Feb 3, 2023
@webkit-commit-queue webkit-commit-queue removed merge-queue Applied to send a pull request to merge-queue request-merge-queue Request a pull request to be added to merge-queue once ready labels Feb 3, 2023
@obyknovenius obyknovenius deleted the wpe/always-use-complex-text-code-path branch February 4, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WPE WebKit WebKit WPE component
Projects
None yet
7 participants