[WinCairo] include secure cookies for secure WebSockets #9514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to add a test for it if someone lets me know where! I did only find WebSocket tests for cocoa and glib so far. |
|
EWS run on previous version of this PR (hash 1103bfa)
|
|
cc @fujii |
fujii
reviewed
Feb 3, 2023
Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
Outdated
Show resolved
Hide resolved
fujii
reviewed
Feb 3, 2023
| { | ||
| // FIXME: This should filter secure cookies out if the caller requests it. | ||
| return { cookiesForSession(*this, firstParty, url, false), false }; | ||
| return { cookiesForSession(*this, firstParty, url, false, includeSecureCookies), false }; |
There was a problem hiding this comment.
The second argument is used for document.setSecureCookiesAccessed. It seems important. https://commits.webkit.org/192473@main It'd be nice, if you properly calculate the second argument in this time.
There was a problem hiding this comment.
We can follow-up on this one since its not related to the bug report and I didn't find an easy way of doing it.
|
EWS run on current version of this PR (hash af31d23)
|
webkit-ews-buildbot
added
the
merging-blocked
fujii
approved these changes
Feb 7, 2023
fujii
added
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=251581 Reviewed by Fujii Hironori. Before this patch for wss:// connections, secure cookies were not includes. This fixes it and includes them. Canonical link: https://commits.webkit.org/259975@main
|
Committed 259975@main (11421fd): https://commits.webkit.org/259975@main Reviewed commits have been landed. Closing PR #9514 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11421fd
af31d23
🧪 api-gtk