New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web-animations] keyframes should be recomputed when a parent element changes value for a custom property set to "inherit" #9525
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
graouts:recompute-keyframes-custom-property-inherit
Feb 3, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graouts
changed the title
[
[web-animations] keyframes should be recomputed when a parent element changes value for a custom property set to "inherit"
Feb 2, 2023
EWS run on previous version of this PR (hash 4ad1997) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Feb 3, 2023
graouts
force-pushed
the
recompute-keyframes-custom-property-inherit
branch
from
February 3, 2023 10:09
4ad1997
to
d9a2eda
Compare
EWS run on current version of this PR (hash d9a2eda) |
anttijk
approved these changes
Feb 3, 2023
graouts
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 3, 2023
β¦ changes value for a custom property set to "inherit" https://bugs.webkit.org/show_bug.cgi?id=251596 Reviewed by Antti Koivisto. We keep a set of CSS properties set to "inherit" in a KeyframeEffect but until now only considered "standard" CSS properties. We now also consider custom properties by changing the set's type from HashSet<CSSPropertyID> to HashSet<AnimatableProperty>. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html: * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateBlendingKeyframes): * Source/WebCore/animation/KeyframeEffect.h: (WebCore::KeyframeEffect::inheritedProperties const): * Source/WebCore/css/CSSCustomPropertyValue.h: * Source/WebCore/style/StyleResolver.cpp: (WebCore::Style::Resolver::keyframeStylesForAnimation): * Source/WebCore/style/StyleResolver.h: Canonical link: https://commits.webkit.org/259812@main
webkit-early-warning-system
force-pushed
the
recompute-keyframes-custom-property-inherit
branch
from
February 3, 2023 13:17
d9a2eda
to
a2b572c
Compare
Committed 259812@main (a2b572c): https://commits.webkit.org/259812@main Reviewed commits have been landed. Closing PR #9525 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a2b572c
d9a2eda
π π§ͺ winπ wincairoπ§ͺ ios-wk2π§ͺ gtk-wk2π§ͺ api-gtkπ§ͺ mac-AS-debug-wk2