Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-animations] keyframes should be recomputed when a parent element changes value for a custom property set to "inherit" #9525

Conversation

graouts
Copy link
Contributor

@graouts graouts commented Feb 2, 2023

a2b572c

[web-animations] keyframes should be recomputed when a parent element changes value for a custom property set to "inherit"
https://bugs.webkit.org/show_bug.cgi?id=251596

Reviewed by Antti Koivisto.

We keep a set of CSS properties set to "inherit" in a KeyframeEffect but until now only considered
"standard" CSS properties. We now also consider custom properties by changing the set's type from
HashSet<CSSPropertyID> to HashSet<AnimatableProperty>.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateBlendingKeyframes):
* Source/WebCore/animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::inheritedProperties const):
* Source/WebCore/css/CSSCustomPropertyValue.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::keyframeStylesForAnimation):
* Source/WebCore/style/StyleResolver.h:

Canonical link: https://commits.webkit.org/259812@main

d9a2eda

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk   πŸ›  wincairo
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim
βœ… πŸ›  πŸ§ͺ unsafe-merge

@graouts graouts self-assigned this Feb 2, 2023
@graouts graouts added the Animations Bugs related to CSS + SVG animations and transitions label Feb 2, 2023
@graouts graouts changed the title [ [web-animations] keyframes should be recomputed when a parent element changes value for a custom property set to "inherit" Feb 2, 2023
@graouts
Copy link
Contributor Author

graouts commented Feb 2, 2023

This PR currently builds on top of #9522 and #9523, only the last commit 4ad1997 would be in the final version of this patch.

@graouts graouts marked this pull request as draft February 2, 2023 17:00
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 3, 2023
@graouts graouts force-pushed the recompute-keyframes-custom-property-inherit branch from 4ad1997 to d9a2eda Compare February 3, 2023 10:09
@graouts graouts removed the merging-blocked Applied to prevent a change from being merged label Feb 3, 2023
@graouts graouts marked this pull request as ready for review February 3, 2023 10:10
@graouts graouts requested a review from anttijk February 3, 2023 10:10
@graouts graouts added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 3, 2023
… changes value for a custom property set to "inherit"

https://bugs.webkit.org/show_bug.cgi?id=251596

Reviewed by Antti Koivisto.

We keep a set of CSS properties set to "inherit" in a KeyframeEffect but until now only considered
"standard" CSS properties. We now also consider custom properties by changing the set's type from
HashSet<CSSPropertyID> to HashSet<AnimatableProperty>.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateBlendingKeyframes):
* Source/WebCore/animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::inheritedProperties const):
* Source/WebCore/css/CSSCustomPropertyValue.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::keyframeStylesForAnimation):
* Source/WebCore/style/StyleResolver.h:

Canonical link: https://commits.webkit.org/259812@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the recompute-keyframes-custom-property-inherit branch from d9a2eda to a2b572c Compare February 3, 2023 13:17
@webkit-commit-queue
Copy link
Collaborator

Committed 259812@main (a2b572c): https://commits.webkit.org/259812@main

Reviewed commits have been landed. Closing PR #9525 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit a2b572c into WebKit:main Feb 3, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 3, 2023
@graouts graouts deleted the recompute-keyframes-custom-property-inherit branch February 3, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Animations Bugs related to CSS + SVG animations and transitions
Projects
None yet
5 participants