Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref document in Document::postTask() lambda to make sure it stays alive during the task execution #9609

Merged
merged 1 commit into from Feb 3, 2023
Merged

Ref document in Document::postTask() lambda to make sure it stays alive during the task execution #9609

merged 1 commit into from Feb 3, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Feb 3, 2023 •
edited by webkit-early-warning-system

f223f58

Ref document in Document::postTask() lambda to make sure it stays alive during the task execution
https://bugs.webkit.org/show_bug.cgi?id=251695

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):

Canonical link: https://commits.webkit.org/259841@main

33d6ca2

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez requested a review from rniwa as a code owner February 3, 2023 17:46
@cdumez cdumez self-assigned this Feb 3, 2023
@cdumez cdumez added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Feb 3, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash b0aa02f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
⏳ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim

@cdumez cdumez changed the title Ref document in Document::postTask() lambda to make sure it stay alive during the task execution Ref document in Document::postTask() lambda to make sure it stays alive during the task execution Feb 3, 2023
@cdumez cdumez force-pushed the 251695_Document_postTask_ref branch from b0aa02f to 33d6ca2 Compare February 3, 2023 18:28
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 33d6ca2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Feb 3, 2023
@cdumez
Ref document in Document::postTask() lambda to make sure it stays ali…
f223f58 
…ve during the task execution

https://bugs.webkit.org/show_bug.cgi?id=251695

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):

Canonical link: https://commits.webkit.org/259841@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259841@main (f223f58): https://commits.webkit.org/259841@main

Reviewed commits have been landed. Closing PR #9609 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit f223f58 into WebKit:main Feb 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

@youennf youennf Awaiting requested review from youennf

@achristensen07 achristensen07 Awaiting requested review from achristensen07

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@cdumez cdumez

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @rniwa