Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Inspector: Don't show ::backdrop rules for elements without a backdrop #9638

Conversation

patrickangle
Copy link
Contributor

@patrickangle patrickangle commented Feb 4, 2023

c5064e5

Web Inspector: Don't show `::backdrop` rules for elements without a backdrop
https://bugs.webkit.org/show_bug.cgi?id=251466
rdar://104889944

Reviewed by Tim Nguyen.

`::backdrop` only applies to elements in the top layer. Like `::marker`, we should not display this selector for elements it can't apply to.

* LayoutTests/inspector/css/getMatchedStylesForNode.html:
* LayoutTests/inspector/css/getMatchedStylesForNodeBackdropPseudoId-expected.txt: Added.
* LayoutTests/inspector/css/getMatchedStylesForNodeBackdropPseudoId.html: Added.
* Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):

Canonical link: https://commits.webkit.org/259894@main

ab7da9b

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe ❌ πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@patrickangle patrickangle self-assigned this Feb 4, 2023
@patrickangle patrickangle added the Web Inspector Bugs related to the WebKit Web Inspector. label Feb 4, 2023
@patrickangle patrickangle added the merge-queue Applied to send a pull request to merge-queue label Feb 6, 2023
…ackdrop

https://bugs.webkit.org/show_bug.cgi?id=251466
rdar://104889944

Reviewed by Tim Nguyen.

`::backdrop` only applies to elements in the top layer. Like `::marker`, we should not display this selector for elements it can't apply to.

* LayoutTests/inspector/css/getMatchedStylesForNode.html:
* LayoutTests/inspector/css/getMatchedStylesForNodeBackdropPseudoId-expected.txt: Added.
* LayoutTests/inspector/css/getMatchedStylesForNodeBackdropPseudoId.html: Added.
* Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):

Canonical link: https://commits.webkit.org/259894@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/b251466-wi-supress-css-backdrop-on-non-applicable-elements branch from ab7da9b to c5064e5 Compare February 6, 2023 16:53
@webkit-commit-queue
Copy link
Collaborator

Committed 259894@main (c5064e5): https://commits.webkit.org/259894@main

Reviewed commits have been landed. Closing PR #9638 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit c5064e5 into WebKit:main Feb 6, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
4 participants