Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Running layout tests in fast/forms leaves a popup visible in the top left of the window, breaking all typing #9646

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

pxlcoder
Copy link
Member

@pxlcoder pxlcoder commented Feb 4, 2023

69938db

[macOS] Running layout tests in fast/forms leaves a popup visible in the top left of the window, breaking all typing
https://bugs.webkit.org/show_bug.cgi?id=251740
rdar://104719873

Reviewed by Wenson Hsieh.

226753@main began swizzling methods on `NSMenu` and `NSCarbonMenuImpl` so that
tests that present system popups could be run simultaneously. To support this
behavior, layout tests never actually present popup menus. However, the class
of the underlying menu implementation is configuration dependent. This means
that the correct method is not always swizzled, resulting in popups being
presented unexpectedly.

To fix, obtain the underlying menu implementation at runtime, ensuring that
the correct method is swizzled.

* Tools/WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::menuImplClass):
(WTR::TestController::platformInitialize):

Canonical link: https://commits.webkit.org/259872@main

b57aef7

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@pxlcoder pxlcoder self-assigned this Feb 4, 2023
@pxlcoder pxlcoder added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 4, 2023
@pxlcoder pxlcoder added the merge-queue Applied to send a pull request to merge-queue label Feb 5, 2023
…the top left of the window, breaking all typing

https://bugs.webkit.org/show_bug.cgi?id=251740
rdar://104719873

Reviewed by Wenson Hsieh.

226753@main began swizzling methods on `NSMenu` and `NSCarbonMenuImpl` so that
tests that present system popups could be run simultaneously. To support this
behavior, layout tests never actually present popup menus. However, the class
of the underlying menu implementation is configuration dependent. This means
that the correct method is not always swizzled, resulting in popups being
presented unexpectedly.

To fix, obtain the underlying menu implementation at runtime, ensuring that
the correct method is swizzled.

* Tools/WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::menuImplClass):
(WTR::TestController::platformInitialize):

Canonical link: https://commits.webkit.org/259872@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259872@main (69938db): https://commits.webkit.org/259872@main

Reviewed commits have been landed. Closing PR #9646 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 69938db into WebKit:main Feb 5, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants