SQLiteStorageArea should start new transaction when the previous one is rolled back by sqlite #9660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szewai
added
the
Website Storage
|
EWS run on previous version of this PR (hash 0e6afe6)
|
Typo: implciti |
cdumez
approved these changes
Feb 6, 2023
szewai
force-pushed
the
eng/SQLiteStorageArea-should-start-new-transaction-when-the-previous-one-is-rolled-back-by-sqlite
branch
from
0e6afe6
to
90e6d10
Compare
|
EWS run on current version of this PR (hash 90e6d10)
|
…is rolled back by sqlite https://bugs.webkit.org/show_bug.cgi?id=251764 rdar://105061923 Reviewed by Chris Dumez. When debugging storage_local_setitem_quotaexceedederr.window.html failure, I found SQLiteStorageArea does not start new transaction after SQLITE_FULL error, which means it would create an implicit transaction for each statement. To fix this, this patch makes startTransactionIfNecessary() check whether existing transaction is already rolled back. If the transaction is rolled back, it should start a new transaction. * Source/WebCore/platform/sql/SQLiteTransaction.h: * Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp: (WebKit::SQLiteStorageArea::startTransactionIfNecessary): Canonical link: https://commits.webkit.org/259966@main
webkit-commit-queue
force-pushed
the
eng/SQLiteStorageArea-should-start-new-transaction-when-the-previous-one-is-rolled-back-by-sqlite
branch
from
90e6d10
to
7833f1f
Compare
|
Committed 259966@main (7833f1f): https://commits.webkit.org/259966@main Reviewed commits have been landed. Closing PR #9660 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7833f1f
90e6d10
🛠 ios🛠 mac🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim