Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Call to GSFontInitialize() #9705

Closed
wants to merge 1 commit into from
Closed

Remove Call to GSFontInitialize() #9705

wants to merge 1 commit into from

Conversation

AtariDreams
Copy link
Contributor

@AtariDreams AtariDreams commented Feb 6, 2023 •
edited by webkit-early-warning-system

508f25c

Remove Call to GSFontInitialize()
https://bugs.webkit.org/show_bug.cgi?id=251807
<rdar://problem/32886715>

Reviewed by NOBODY (OOPS!).

Now that <rdar://problem/32886715> has been addressed, we can remove
this function call. So basically, revert commit
5bea31adfd254b9b192498abdd9852e51442bbd2

*Source\WebCore\PAL\pal\spi\ios\GraphicsServicesSPI.h:
*Source\WebCore\page\cocoa\MemoryReleaseCocoa.mm:

508f25c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 971c2d1)

Misc iOS, tvOS & watchOS macOS Linux Windows
  🧪 style   🛠 ios   🛠 mac ✅ 🛠 wpe 💥 🛠 🧪 win
✅ 🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
  🛠 tv   🧪 mac-wk2
  🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch   🧪 mac-wk2-stress
  🛠 watch-sim

@AtariDreams AtariDreams force-pushed the eng/Remove-call-to-GSFontInitialize branch from 971c2d1 to 56b1ed9 Compare February 6, 2023 19:33
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 56b1ed9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 💥 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@AtariDreams AtariDreams force-pushed the eng/Remove-call-to-GSFontInitialize branch from 56b1ed9 to 976169d Compare February 6, 2023 23:04
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 976169d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@nt1m nt1m requested review from litherum and heycam February 7, 2023 20:11
@AtariDreams
Remove Call to GSFontInitialize()
508f25c 
https://bugs.webkit.org/show_bug.cgi?id=251807
<rdar://problem/32886715>

Reviewed by NOBODY (OOPS!).

Now that <rdar://problem/32886715> has been addressed, we can remove
this function call. So basically, revert commit
5bea31a

*Source\WebCore\PAL\pal\spi\ios\GraphicsServicesSPI.h:
*Source\WebCore\page\cocoa\MemoryReleaseCocoa.mm:
@AtariDreams
Copy link
Contributor Author

@cdumez Do you think we can merge this one?

@AtariDreams AtariDreams force-pushed the eng/Remove-call-to-GSFontInitialize branch from 976169d to 508f25c Compare February 10, 2023 18:51
@AtariDreams AtariDreams changed the title Remove call to GSFontInitialize() Remove Call to GSFontInitialize() Feb 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 508f25c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@cdumez
Copy link
Contributor

cdumez commented Feb 10, 2023

@cdumez Do you think we can merge this one?

Where do you see that rdar://problem/32886715 was addressed?

brentfulgham
brentfulgham reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we can safely remove the call to GSFontInitialize(). As far as I can tell, the underlying framework retains the behavior present when @cdumez added this code, and I see no reason why it would be safe to remove it.

If you know that this bug was fixed through some change other than rdar://problem/32886715, please let me know and I'll happily support removing it!

Thank you!

Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm Show resolved Hide resolved
@AtariDreams AtariDreams deleted the eng/Remove-call-to-GSFontInitialize branch February 11, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m left review comments

@brentfulgham brentfulgham brentfulgham left review comments

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@litherum litherum Awaiting requested review from litherum

@heycam heycam Awaiting requested review from heycam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@AtariDreams @webkit-early-warning-system @cdumez @nt1m @brentfulgham