Fix IPC tests in debug asan builds #9710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash 04628c7)
|
kkinnunen-apple
approved these changes
Feb 7, 2023
| @@ -390,7 +390,7 @@ TEST_P(StreamMessageTest, SendAsyncReplyCancel) | |||
| auto cleanup = localReferenceBarrier(); | |||
|
|
|||
| std::atomic<bool> waiting; | |||
| BinarySemaphore workQueueWait; | |||
| static BinarySemaphore workQueueWait; | |||
There was a problem hiding this comment.
Same problem exists with the waiting variable.
This could be instead:
TEST_P(StreamMessageTest, SendAsyncReplyCancel)
{
auto cleanup = localReferenceBarrier();
04628c7
to
ba191c9
Compare
achristensen07
added
the
merge-queue
|
EWS run on current version of this PR (hash ba191c9)
|
https://bugs.webkit.org/show_bug.cgi?id=251813 Reviewed by Kimmo Kinnunen. There were two issues: 1. workQueueWait was referenced after its stack scope during test tear-down. Make it static to extend its scope past the '}' 2. ReceiveAlreadyInvalidatedClientNoAssert hit a stack overflow because asan uses a little more stack space. Just reduce 1000 iterations to 800 to make that test also run successfully. * Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp: (TestWebKitAPI::TEST_P): * Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp: (TestWebKitAPI::TEST_P): Canonical link: https://commits.webkit.org/260099@main
webkit-early-warning-system
force-pushed
the
eng/Fix-IPC-tests-in-debug-asan-builds
branch
from
ba191c9
to
49c6254
Compare
|
Committed 260099@main (49c6254): https://commits.webkit.org/260099@main Reviewed commits have been landed. Closing PR #9710 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
49c6254
ba191c9
🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 watch