Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused RenderTheme video-related methods #972

Merged
merged 0 commits into from May 24, 2022
Merged

Remove unused RenderTheme video-related methods #972

merged 0 commits into from May 24, 2022

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented May 24, 2022 •
edited by webkit-early-warning-system

b85b20b

Remove unused RenderTheme video-related methods
https://bugs.webkit.org/show_bug.cgi?id=240862

Reviewed by Antoine Quint.

* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::hasVerticalAppearance):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::formatMediaControlsTime const): Deleted.
(WebCore::RenderTheme::formatMediaControlsCurrentTime const): Deleted.
(WebCore::RenderTheme::formatMediaControlsRemainingTime const): Deleted.
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton const): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::supportsClosedCaptioning const): Deleted.
(WebCore::RenderTheme::hasOwnDisabledStateHandlingFor const): Deleted.
(WebCore::RenderTheme::usesMediaControlStatusDisplay): Deleted.
(WebCore::RenderTheme::usesMediaControlVolumeSlider const): Deleted.
(WebCore::RenderTheme::usesVerticalVolumeSlider const): Deleted.
(WebCore::RenderTheme::mediaControlsFadeInDuration): Deleted.
(WebCore::RenderTheme::mediaControlsFadeOutDuration): Deleted.
* Source/WebCore/rendering/RenderThemeMac.h:
(WebCore::RenderThemeMac::supportsClosedCaptioning const final): Deleted.

Canonical link: https://commits.webkit.org/250914@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@nt1m nt1m self-assigned this May 24, 2022
@nt1m nt1m added Layout and Rendering For bugs with layout and rendering of Web pages. WebKit Nightly Build labels May 24, 2022
@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label May 24, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit b85b20b into WebKit:main May 24, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294746 (250914@main): https://commits.webkit.org/250914@main

Reviewed commits have been landed. Closing PR #972 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2022
@nt1m nt1m deleted the rm-unused-video branch May 24, 2022 15:13
eocanha pushed a commit to eocanha/WebKit that referenced this pull request Feb 8, 2023
@magomez
Merge pull request WebKit#972 from lauromoura/features-json-2.38
aa93d81 
Update feature list for 2.38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graouts graouts graouts approved these changes

@anttijk anttijk Awaiting requested review from anttijk

@eric-carlson eric-carlson Awaiting requested review from eric-carlson

@jernoble jernoble Awaiting requested review from jernoble

Assignees

@nt1m nt1m

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
3 participants
@nt1m @webkit-early-warning-system @graouts