Range APIs do not construct / move trees in tree order (observable by custom elements) #9730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
the
DOM
|
EWS run on previous version of this PR (hash 1d8c5e1)
|
cdumez
approved these changes
Feb 7, 2023
Source/WebCore/dom/Range.cpp
Outdated
| RangeBoundaryPoint originalEnd(m_end); | ||
|
|
||
| // what is the highest node that partially selects the start / end of the range? | ||
| RefPtr<Node> partialStart = highestAncestorUnderCommonRoot(&originalStart.container(), commonRoot.get()); |
There was a problem hiding this comment.
Would RefPtr suffice instead of RefPtr<Node>?
|
EWS run on current version of this PR (hash fcd1be1)
|
rniwa
added
the
unsafe-merge-queue
… custom elements) https://bugs.webkit.org/show_bug.cgi?id=188279 Reviewed by Chris Dumez. In order to match the spec'ed upgrade order, create a nested custom element reaction stack which is used as a holding tank of upgrade reactions during Range::processContents. At the end, we traverse the document fragment top-down and re-enqueue each element to the real custom element reaction stack in the tree order. * LayoutTests/imported/w3c/web-platform-tests/custom-elements/range-and-constructors-expected.txt: * Source/WebCore/dom/CustomElementReactionQueue.cpp: (WebCore::CustomElementQueue::takeElements): Added. (WebCore::CustomElementReactionQueue::enqueueElementsOnAppropriateElementQueue): Added. (WebCore::CustomElementReactionStack::takeElements): Added. * Source/WebCore/dom/CustomElementReactionQueue.h: * Source/WebCore/dom/Range.cpp: (WebCore::Range::processContents): Canonical link: https://commits.webkit.org/259987@main
webkit-early-warning-system
force-pushed
the
fix188279
branch
from
fcd1be1
to
fa5a06a
Compare
|
Committed 259987@main (fa5a06a): https://commits.webkit.org/259987@main Reviewed commits have been landed. Closing PR #9730 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fa5a06a
fcd1be1
🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2