Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebKitTestRunner crashes when run with --world-leaks #9737

Conversation

smfr
Copy link
Contributor

@smfr smfr commented Feb 7, 2023

dda8230

WebKitTestRunner crashes when run with --world-leaks
https://bugs.webkit.org/show_bug.cgi?id=251834
rdar://105112156

Reviewed by Cameron McCormack.

Document::identifier() (aka ScriptExecutionContext::identifier()) is now a UUID, which doesn't convert to a uint64_t,
so just convert it to a string for the abandoned documents hash key.

* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveLiveDocumentsList):
* Tools/WebKitTestRunner/TestController.h:

Canonical link: https://commits.webkit.org/259965@main

3d6ce69

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@smfr smfr requested a review from JonWBedard as a code owner February 7, 2023 04:59
@smfr smfr self-assigned this Feb 7, 2023
@smfr smfr added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 7, 2023
@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label Feb 7, 2023
https://bugs.webkit.org/show_bug.cgi?id=251834
rdar://105112156

Reviewed by Cameron McCormack.

Document::identifier() (aka ScriptExecutionContext::identifier()) is now a UUID, which doesn't convert to a uint64_t,
so just convert it to a string for the abandoned documents hash key.

* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveLiveDocumentsList):
* Tools/WebKitTestRunner/TestController.h:

Canonical link: https://commits.webkit.org/259965@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/WebKitTestRunner-crashes-when-run-with---world-leaks branch from 3d6ce69 to dda8230 Compare February 7, 2023 18:09
@webkit-commit-queue
Copy link
Collaborator

Committed 259965@main (dda8230): https://commits.webkit.org/259965@main

Reviewed commits have been landed. Closing PR #9737 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit dda8230 into WebKit:main Feb 7, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 7, 2023
@smfr smfr deleted the eng/WebKitTestRunner-crashes-when-run-with---world-leaks branch February 22, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants