Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-webkit-tests a/b shouldn't run platform/mac/a/b #9753

Merged
merged 0 commits into from May 17, 2023

Conversation

gsnedders
Copy link
Contributor

@gsnedders gsnedders commented Feb 7, 2023

3c10a48

run-webkit-tests a/b shouldn't run platform/mac/a/b
https://bugs.webkit.org/show_bug.cgi?id=251847

Reviewed by Jonathan Bedard.

If you want the prior behaviour, you must run
`run-webkit-tests a/b 'platform/*/a/b'`.

* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py:
(LayoutTestFinder.find_tests_by_path): Remove _expanded_paths.
(LayoutTestFinder._expanded_paths): Deleted.
* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py:
(LayoutTestFinderTests.test_find_platform_specific): Renamed to test_find_file_excludes_platform_specific.
(LayoutTestFinderTests.test_find_directory_includes_platform_specific): Renamed to test_find_directory_excludes_platform_specific, changed expectation.
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.serial_test_platform_tests_are_not_found):
(RunTest.serial_test_platform_tests_are_found): Renamed to serial_test_platform_tests_are_not_found, changed expectation.

Canonical link: https://commits.webkit.org/264151@main

c03a6fc

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug ⏳ πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ webkitpy ⏳ πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv ❌ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@gsnedders gsnedders self-assigned this Feb 7, 2023
@gsnedders gsnedders added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Feb 7, 2023
@gsnedders gsnedders changed the title run-webkit-tests a/b.html shouldn't run platform/mac/a/b.html run-webkit-tests a/b shouldn't run platform/mac/a/b Feb 7, 2023
@gsnedders
Copy link
Contributor Author

(That push was purely a commit message change)

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 8, 2023
@JonWBedard JonWBedard removed the merging-blocked Applied to prevent a change from being merged label May 17, 2023
@gsnedders gsnedders added the merge-queue Applied to send a pull request to merge-queue label May 17, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 264151@main (3c10a48): https://commits.webkit.org/264151@main

Reviewed commits have been landed. Closing PR #9753 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 17, 2023
@webkit-commit-queue webkit-commit-queue merged commit 3c10a48 into WebKit:main May 17, 2023
@gsnedders gsnedders deleted the no_implicit_platform branch May 17, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
5 participants