Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Check SIMD existence for call's return value / catch's value #9773

Merged
merged 1 commit into from Feb 7, 2023
Merged

[JSC] Check SIMD existence for call's return value / catch's value #9773

merged 1 commit into from Feb 7, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Feb 7, 2023 •
edited by webkit-early-warning-system

d42da31

[JSC] Check SIMD existence for call's return value / catch's value
https://bugs.webkit.org/show_bug.cgi?id=251878
rdar://105124299

Reviewed by Mark Lam.

Function calls / catch can generate new SIMD values. So we need to check types of them, and let generator know SIMD existence when we see it.

* JSTests/wasm/stress/call-returns-v128.js: Added.
(let.fn0):
(async let):
* JSTests/wasm/stress/resources/call-returns-v128.wasm: Added.
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

Canonical link: https://commits.webkit.org/259980@main

90e5dde

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
  🛠 🧪 jsc   🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ❌ 🧪 jsc-armv7-tests
✅ 🛠 watch   🧪 mac-wk2-stress ✅ 🛠 jsc-mips
  🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

@Constellation Constellation requested a review from a team as a code owner February 7, 2023 20:29
@Constellation Constellation self-assigned this Feb 7, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Feb 7, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 90e5dde)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
  🛠 🧪 jsc   🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ❌ 🧪 jsc-armv7-tests
✅ 🛠 watch   🧪 mac-wk2-stress ✅ 🛠 jsc-mips
  🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

MenloDorian
MenloDorian approved these changes Feb 7, 2023
View reviewed changes
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 7, 2023
@Constellation
[JSC] Check SIMD existence for call's return value / catch's value
d42da31 
https://bugs.webkit.org/show_bug.cgi?id=251878
rdar://105124299

Reviewed by Mark Lam.

Function calls / catch can generate new SIMD values. So we need to check types of them, and let generator know SIMD existence when we see it.

* JSTests/wasm/stress/call-returns-v128.js: Added.
(let.fn0):
(async let):
* JSTests/wasm/stress/resources/call-returns-v128.wasm: Added.
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

Canonical link: https://commits.webkit.org/259980@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Check-SIMD-existence-for-calls-return-value--catchs-value branch from 90e5dde to d42da31 Compare February 7, 2023 21:42
@webkit-commit-queue webkit-commit-queue merged commit d42da31 into WebKit:main Feb 7, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 259980@main (d42da31): https://commits.webkit.org/259980@main

Reviewed commits have been landed. Closing PR #9773 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 7, 2023
@Constellation Constellation deleted the eng/JSC-Check-SIMD-existence-for-calls-return-value--catchs-value branch February 7, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MenloDorian MenloDorian MenloDorian approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @MenloDorian