[Cocoa] Use new screen/window picker API when available #9789

eric-carlson · 2023-02-08T01:00:48Z

`fe99ba1`

[Cocoa] Use new screen/window picker API when available
https://bugs.webkit.org/show_bug.cgi?id=251893
rdar://101206117

Reviewed by Jer Noble.

* Source/WebCore/Headers.cmake: Add DisplayCapturePromptType.h.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj: Ditto.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: SC_CONTENT_SHARING_SESSION -> SCREEN_CAPTURE_KIT.
Add new runtime preference.

* Source/WTF/wtf/PlatformHave.h: Remove HAVE_SC_CONTENT_SHARING_SESSION.

* Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.h:SCStreamFrameInfoStatus
is always available when ScreenCaptureKit is available.
* Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.mm:
* Source/WebCore/PAL/pal/spi/mac/ScreenCaptureKitSPI.h:

* Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
(WebKit::defaultUseSCContentSharingPicker): Initialize to feature flag value.
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:

* Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::setUseSCContentSharingPicker): New preference access.
(WebCore::PlatformMediaSessionManager::useSCContentSharingPicker):
* Source/WebCore/platform/audio/PlatformMediaSessionManager.h:

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
Rewrite to not be a direct `SCContentSharingSession` delegate and to not create `SCContentStream`
directly, but to do both through the ScreenCaptureKitSharingSessionManager.h.

(-[WebCoreScreenCaptureKitHelper stream:didStopWithError:]):
(-[WebCoreScreenCaptureKitHelper stream:didOutputSampleBuffer:ofType:]):
(WebCore::ScreenCaptureKitCaptureSource::~ScreenCaptureKitCaptureSource):
(WebCore::ScreenCaptureKitCaptureSource::stop):
(WebCore::ScreenCaptureKitCaptureSource::sessionFailedWithError):
(WebCore::ScreenCaptureKitCaptureSource::sessionFilterDidChange):
(WebCore::ScreenCaptureKitCaptureSource::sessionStreamDidEnd):
(WebCore::ScreenCaptureKitCaptureSource::startContentStream):
(WebCore::ScreenCaptureKitCaptureSource::updateStreamConfiguration):
(WebCore::ScreenCaptureKitCaptureSource::commitConfiguration):
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer):
(-[WebCoreScreenCaptureKitHelper sessionDidEnd:]): Deleted.
(-[WebCoreScreenCaptureKitHelper sessionDidChangeContent:]): Deleted.
(-[WebCoreScreenCaptureKitHelper pickerCanceledForSession:]): Deleted.
(WebCore::ScreenCaptureKitCaptureSource::streamFailedWithError): Deleted.
(WebCore::ScreenCaptureKitCaptureSource::sessionDidChangeContent): Deleted.
(WebCore::ScreenCaptureKitCaptureSource::sessionDidEnd): Deleted.
(WebCore::findSharableDevice): Deleted.
(WebCore::ScreenCaptureKitCaptureSource::findShareableContent): Deleted.
(WebCore::ScreenCaptureKitCaptureSource::frameAvailableHandler): Deleted.
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputSampleBuffer): Deleted.
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h:
(WebCore::ScreenCaptureSessionSource::stream const):
(WebCore::ScreenCaptureSessionSource::contentFilter const):
(WebCore::ScreenCaptureSessionSource::sharingSession const):
(WebCore::ScreenCaptureSessionSource::observer const):

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm:
Don't pass ownership of `SCContentSharingSession` to ScreenCaptureSessionSource, instead
pass necessary information through ScreenCaptureSessionSource interface to source.

(-[WebDisplayMediaPromptHelper initWithCallback:]):
(-[WebDisplayMediaPromptHelper sessionDidEnd:]):
(-[WebDisplayMediaPromptHelper sessionDidChangeContent:]):
(-[WebDisplayMediaPromptHelper pickerCanceledForSession:]):
(-[WebDisplayMediaPromptHelper contentSharingPicker:didSelectFilter:forStream:]):
(-[WebDisplayMediaPromptHelper contentSharingPickerDidCancel:forStream:]):
(-[WebDisplayMediaPromptHelper contentSharingPickerStartDidFailWithError:]):
(-[WebDisplayMediaPromptHelper contentSharingPicker:didRequestNewStreamWithFilter:]):
(-[WebDisplayMediaPromptHelper contentSharingPicker:didRequestUpdateWithFilter:forStream:]):
(WebCore::ScreenCaptureKitSharingSessionManager::isAvailable):
(WebCore::ScreenCaptureKitSharingSessionManager::useSCContentSharingPicker):
(WebCore::ScreenCaptureKitSharingSessionManager::~ScreenCaptureKitSharingSessionManager):
(WebCore::ScreenCaptureKitSharingSessionManager::cancelPicking):
(WebCore::ScreenCaptureKitSharingSessionManager::completeDeviceSelection):
(WebCore::ScreenCaptureKitSharingSessionManager::findActiveSource):
(WebCore::ScreenCaptureKitSharingSessionManager::sharingSessionDidEnd):
(WebCore::ScreenCaptureKitSharingSessionManager::sharingSessionDidChangeContent):
(WebCore::ScreenCaptureKitSharingSessionManager::contentSharingPickerSelectedFilterForStream):
(WebCore::ScreenCaptureKitSharingSessionManager::contentSharingPickerUpdatedFilterForStream):
(WebCore::ScreenCaptureKitSharingSessionManager::promptForGetDisplayMedia):
(WebCore::ScreenCaptureKitSharingSessionManager::promptWithSCContentSharingSession):
(WebCore::ScreenCaptureKitSharingSessionManager::promptWithSCContentSharingPicker):
(WebCore::ScreenCaptureKitSharingSessionManager::contentSharingPickerFailedWithError):
(WebCore::operator==):
(WebCore::ScreenCaptureKitSharingSessionManager::createSessionSourceForDevice):
(WebCore::ScreenCaptureKitSharingSessionManager::cleanupSessionSource):
(WebCore::ScreenCaptureSessionSource::create):
(WebCore::ScreenCaptureSessionSource::ScreenCaptureSessionSource):
(WebCore::ScreenCaptureSessionSource::~ScreenCaptureSessionSource):
(WebCore::ScreenCaptureSessionSource::operator== const):
(WebCore::screenCaptureKitPickerFeatureEnabled): Deleted.
(WebCore::ScreenCaptureKitSharingSessionManager::pickerCanceledForSession): Deleted.
(WebCore::ScreenCaptureKitSharingSessionManager::sessionDidEnd): Deleted.
(WebCore::ScreenCaptureKitSharingSessionManager::sessionDidChangeContent): Deleted.
(WebCore::ScreenCaptureKitSharingSessionManager::showWindowPicker): Deleted.
(WebCore::ScreenCaptureKitSharingSessionManager::showScreenPicker): Deleted.
(WebCore::ScreenCaptureKitSharingSessionManager::takeSharingSessionForFilter): Deleted.

* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::promptForGetDisplayMedia): Combine showWindowPicker and showScreenPicker.
(WebKit::GPUProcess::showWindowPicker): Deleted.
(WebKit::GPUProcess::showScreenPicker): Deleted.
* Source/WebKit/GPUProcess/GPUProcess.h:
* Source/WebKit/GPUProcess/GPUProcess.messages.in:
* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::promptForDisplayCapturePermission): Cleanup and simplify.
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):

* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: SC_CONTENT_SHARING_SESSION -> SCREEN_CAPTURE_KIT

* Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::updateSandboxAccess): Ditto.
(WebKit::GPUProcessProxy::promptForGetDisplayMedia):
(WebKit::GPUProcessProxy::showWindowPicker): Deleted.
(WebKit::GPUProcessProxy::showScreenPicker): Deleted.
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:

* Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.cpp:
(WebKit::UserMediaPermissionRequestProxy::promptForGetDisplayMedia): canPromptForGetDisplayMedia ->
canRequestDisplayCapturePermission.
(WebKit::UserMediaPermissionRequestProxy::doDefaultAction):
(WebKit::UserMediaPermissionRequestProxy::canRequestDisplayCapturePermission): Rename from
canPromptForGetDisplayMedia.
(WebKit::UserMediaPermissionRequestProxy::canPromptForGetDisplayMedia): Deleted.
* Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:

* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _setSystemCanPromptForGetDisplayMediaForTesting:]): Simulate when system can
and can not prompt for type of display capture.

* Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.h:
* Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm:
(WebKit::DisplayCaptureSessionManager::showWindowPicker):
(WebKit::DisplayCaptureSessionManager::showScreenPicker):
(WebKit::DisplayCaptureSessionManager::canRequestDisplayCapturePermission):
(WebKit::toScreenCaptureKitPromptType):
(WebKit::DisplayCaptureSessionManager::promptForGetDisplayMedia):

* Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.h:
* Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.mm:
(WebKit::UserMediaPermissionRequestProxyMac::promptForGetDisplayMedia):
(WebKit::UserMediaPermissionRequestProxyMac::canRequestDisplayCapturePermission):
(WebKit::UserMediaPermissionRequestProxyMac::canPromptForGetDisplayMedia): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

* Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Test when system can and can
not prompt for type of capture.
(-[GetDisplayMediaUIDelegate _webView:requestDisplayCapturePermissionForOrigin:initiatedByFrame:withSystemAudio:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):
(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]): Deleted.

Canonical link: https://commits.webkit.org/261180@main

e37c1d9

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
~~🛠 🧪 jsc~~	~~🛠 tv~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	~~🛠 tv-sim~~	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-armv7-tests
~~🛠 🧪 merge~~	~~🛠 watch-sim~~		✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge			✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-08T01:06:18Z

EWS run on previous version of this PR (hash 6e7c917)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-08T02:21:56Z

EWS run on previous version of this PR (hash f8837f9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	~~🧪 mac-wk1~~	⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk2~~	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-08T02:59:46Z

EWS run on previous version of this PR (hash 74eff18)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-08T18:08:23Z

EWS run on previous version of this PR (hash d52283d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk2~~	⏳ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-08T21:05:35Z

EWS run on previous version of this PR (hash b88334d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-24T16:52:31Z

EWS run on previous version of this PR (hash 309c521)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	⏳ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 wincairo
✅ 🧪 bindings	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	✅ 🛠 gtk
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-24T16:54:28Z

EWS run on previous version of this PR (hash 5638682)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-27T15:33:20Z

EWS run on previous version of this PR (hash 14e91b9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-03-01T01:26:04Z

EWS run on previous version of this PR (hash 40f5b24)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

youennf · 2023-02-24T17:23:42Z

Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

 {
    ASSERT(isMainThread());
+    ASSERT(sampleBuffer);


We should avoid going through main thread at some point.

Yes, lets do that in a followup.

Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm

Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.h

Source/WebCore/platform/mediastream/DisplayCapturePromptType.h

Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h

youennf · 2023-03-01T18:16:12Z

Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

-        if (!strongSelf->_callback)
+    ASSERT(type == SCStreamOutputTypeScreen);
+
+    if (!sampleBuffer)


In which case can sampleBuffer be null?

Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm

youennf · 2023-03-01T18:37:32Z

Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp

 {
-    sendWithAsyncReply(Messages::GPUProcess::ShowScreenPicker { }, WTFMove(completionHandler));
+    sendWithAsyncReply(Messages::GPUProcess::PromptForGetDisplayMedia { type }, WTFMove(completionHandler));


Could we pass m_useSCContentSharingPicker here instead of the separate IPC?

Source/WebCore/platform/audio/PlatformMediaSessionManager.h

Source/WebCore/platform/mediastream/DisplayCapturePromptType.h

webkit-early-warning-system · 2023-03-01T22:56:45Z

EWS run on previous version of this PR (hash bcedbec)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	❌ 🛠 tv	⏳ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-03-02T00:23:57Z

EWS run on previous version of this PR (hash 60c27b8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-03-02T19:41:41Z

EWS run on previous version of this PR (hash 1034d18)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2023-03-02T20:28:33Z

EWS run on previous version of this PR (hash 62c864b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc	~~🛠 tv~~	⏳ 🧪 mac-wk2	~~🛠 jsc-armv7~~
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	~~🧪 jsc-armv7-tests~~
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2023-03-02T20:56:24Z

EWS run on previous version of this PR (hash 876e55a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim		✅ 🛠 jsc-mips
			✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-03-03T15:31:31Z

EWS run on previous version of this PR (hash 5eb4f73)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	~~🛠 gtk~~
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	~~🛠 tv~~	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	❌ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	❌ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch-sim		✅ 🛠 jsc-mips
			✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-03-03T21:57:43Z

EWS run on current version of this PR (hash e37c1d9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
~~🛠 🧪 jsc~~	~~🛠 tv~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	~~🛠 tv-sim~~	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-armv7-tests
~~🛠 🧪 merge~~	~~🛠 watch-sim~~		✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge			✅ 🧪 jsc-mips-tests

https://bugs.webkit.org/show_bug.cgi?id=251893 rdar://101206117 Reviewed by Jer Noble. * Source/WebCore/Headers.cmake: Add DisplayCapturePromptType.h. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Ditto. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: SC_CONTENT_SHARING_SESSION -> SCREEN_CAPTURE_KIT. Add new runtime preference. * Source/WTF/wtf/PlatformHave.h: Remove HAVE_SC_CONTENT_SHARING_SESSION. * Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.h:SCStreamFrameInfoStatus is always available when ScreenCaptureKit is available. * Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.mm: * Source/WebCore/PAL/pal/spi/mac/ScreenCaptureKitSPI.h: * Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm: (WebKit::defaultUseSCContentSharingPicker): Initialize to feature flag value. * Source/WebKit/Shared/WebPreferencesDefaultValues.h: * Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::setUseSCContentSharingPicker): New preference access. (WebCore::PlatformMediaSessionManager::useSCContentSharingPicker): * Source/WebCore/platform/audio/PlatformMediaSessionManager.h: * Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h: * Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm: Rewrite to not be a direct `SCContentSharingSession` delegate and to not create `SCContentStream` directly, but to do both through the ScreenCaptureKitSharingSessionManager.h. (-[WebCoreScreenCaptureKitHelper stream:didStopWithError:]): (-[WebCoreScreenCaptureKitHelper stream:didOutputSampleBuffer:ofType:]): (WebCore::ScreenCaptureKitCaptureSource::~ScreenCaptureKitCaptureSource): (WebCore::ScreenCaptureKitCaptureSource::stop): (WebCore::ScreenCaptureKitCaptureSource::sessionFailedWithError): (WebCore::ScreenCaptureKitCaptureSource::sessionFilterDidChange): (WebCore::ScreenCaptureKitCaptureSource::sessionStreamDidEnd): (WebCore::ScreenCaptureKitCaptureSource::startContentStream): (WebCore::ScreenCaptureKitCaptureSource::updateStreamConfiguration): (WebCore::ScreenCaptureKitCaptureSource::commitConfiguration): (WebCore::ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer): (-[WebCoreScreenCaptureKitHelper sessionDidEnd:]): Deleted. (-[WebCoreScreenCaptureKitHelper sessionDidChangeContent:]): Deleted. (-[WebCoreScreenCaptureKitHelper pickerCanceledForSession:]): Deleted. (WebCore::ScreenCaptureKitCaptureSource::streamFailedWithError): Deleted. (WebCore::ScreenCaptureKitCaptureSource::sessionDidChangeContent): Deleted. (WebCore::ScreenCaptureKitCaptureSource::sessionDidEnd): Deleted. (WebCore::findSharableDevice): Deleted. (WebCore::ScreenCaptureKitCaptureSource::findShareableContent): Deleted. (WebCore::ScreenCaptureKitCaptureSource::frameAvailableHandler): Deleted. (WebCore::ScreenCaptureKitCaptureSource::streamDidOutputSampleBuffer): Deleted. * Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h: (WebCore::ScreenCaptureSessionSource::stream const): (WebCore::ScreenCaptureSessionSource::contentFilter const): (WebCore::ScreenCaptureSessionSource::sharingSession const): (WebCore::ScreenCaptureSessionSource::observer const): * Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm: Don't pass ownership of `SCContentSharingSession` to ScreenCaptureSessionSource, instead pass necessary information through ScreenCaptureSessionSource interface to source. (-[WebDisplayMediaPromptHelper initWithCallback:]): (-[WebDisplayMediaPromptHelper sessionDidEnd:]): (-[WebDisplayMediaPromptHelper sessionDidChangeContent:]): (-[WebDisplayMediaPromptHelper pickerCanceledForSession:]): (-[WebDisplayMediaPromptHelper contentSharingPicker:didSelectFilter:forStream:]): (-[WebDisplayMediaPromptHelper contentSharingPickerDidCancel:forStream:]): (-[WebDisplayMediaPromptHelper contentSharingPickerStartDidFailWithError:]): (-[WebDisplayMediaPromptHelper contentSharingPicker:didRequestNewStreamWithFilter:]): (-[WebDisplayMediaPromptHelper contentSharingPicker:didRequestUpdateWithFilter:forStream:]): (WebCore::ScreenCaptureKitSharingSessionManager::isAvailable): (WebCore::ScreenCaptureKitSharingSessionManager::useSCContentSharingPicker): (WebCore::ScreenCaptureKitSharingSessionManager::~ScreenCaptureKitSharingSessionManager): (WebCore::ScreenCaptureKitSharingSessionManager::cancelPicking): (WebCore::ScreenCaptureKitSharingSessionManager::completeDeviceSelection): (WebCore::ScreenCaptureKitSharingSessionManager::findActiveSource): (WebCore::ScreenCaptureKitSharingSessionManager::sharingSessionDidEnd): (WebCore::ScreenCaptureKitSharingSessionManager::sharingSessionDidChangeContent): (WebCore::ScreenCaptureKitSharingSessionManager::contentSharingPickerSelectedFilterForStream): (WebCore::ScreenCaptureKitSharingSessionManager::contentSharingPickerUpdatedFilterForStream): (WebCore::ScreenCaptureKitSharingSessionManager::promptForGetDisplayMedia): (WebCore::ScreenCaptureKitSharingSessionManager::promptWithSCContentSharingSession): (WebCore::ScreenCaptureKitSharingSessionManager::promptWithSCContentSharingPicker): (WebCore::ScreenCaptureKitSharingSessionManager::contentSharingPickerFailedWithError): (WebCore::operator==): (WebCore::ScreenCaptureKitSharingSessionManager::createSessionSourceForDevice): (WebCore::ScreenCaptureKitSharingSessionManager::cleanupSessionSource): (WebCore::ScreenCaptureSessionSource::create): (WebCore::ScreenCaptureSessionSource::ScreenCaptureSessionSource): (WebCore::ScreenCaptureSessionSource::~ScreenCaptureSessionSource): (WebCore::ScreenCaptureSessionSource::operator== const): (WebCore::screenCaptureKitPickerFeatureEnabled): Deleted. (WebCore::ScreenCaptureKitSharingSessionManager::pickerCanceledForSession): Deleted. (WebCore::ScreenCaptureKitSharingSessionManager::sessionDidEnd): Deleted. (WebCore::ScreenCaptureKitSharingSessionManager::sessionDidChangeContent): Deleted. (WebCore::ScreenCaptureKitSharingSessionManager::showWindowPicker): Deleted. (WebCore::ScreenCaptureKitSharingSessionManager::showScreenPicker): Deleted. (WebCore::ScreenCaptureKitSharingSessionManager::takeSharingSessionForFilter): Deleted. * Source/WebKit/GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::promptForGetDisplayMedia): Combine showWindowPicker and showScreenPicker. (WebKit::GPUProcess::showWindowPicker): Deleted. (WebKit::GPUProcess::showScreenPicker): Deleted. * Source/WebKit/GPUProcess/GPUProcess.h: * Source/WebKit/GPUProcess/GPUProcess.messages.in: * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::promptForDisplayCapturePermission): Cleanup and simplify. (WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest): * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: SC_CONTENT_SHARING_SESSION -> SCREEN_CAPTURE_KIT * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::updateSandboxAccess): Ditto. (WebKit::GPUProcessProxy::promptForGetDisplayMedia): (WebKit::GPUProcessProxy::showWindowPicker): Deleted. (WebKit::GPUProcessProxy::showScreenPicker): Deleted. * Source/WebKit/UIProcess/GPU/GPUProcessProxy.h: * Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.cpp: (WebKit::UserMediaPermissionRequestProxy::promptForGetDisplayMedia): canPromptForGetDisplayMedia -> canRequestDisplayCapturePermission. (WebKit::UserMediaPermissionRequestProxy::doDefaultAction): (WebKit::UserMediaPermissionRequestProxy::canRequestDisplayCapturePermission): Rename from canPromptForGetDisplayMedia. (WebKit::UserMediaPermissionRequestProxy::canPromptForGetDisplayMedia): Deleted. * Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _setSystemCanPromptForGetDisplayMediaForTesting:]): Simulate when system can and can not prompt for type of display capture. * Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.h: * Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm: (WebKit::DisplayCaptureSessionManager::showWindowPicker): (WebKit::DisplayCaptureSessionManager::showScreenPicker): (WebKit::DisplayCaptureSessionManager::canRequestDisplayCapturePermission): (WebKit::toScreenCaptureKitPromptType): (WebKit::DisplayCaptureSessionManager::promptForGetDisplayMedia): * Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.h: * Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.mm: (WebKit::UserMediaPermissionRequestProxyMac::promptForGetDisplayMedia): (WebKit::UserMediaPermissionRequestProxyMac::canRequestDisplayCapturePermission): (WebKit::UserMediaPermissionRequestProxyMac::canPromptForGetDisplayMedia): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): * Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Test when system can and can not prompt for type of capture. (-[GetDisplayMediaUIDelegate _webView:requestDisplayCapturePermissionForOrigin:initiatedByFrame:withSystemAudio:decisionHandler:]): (TestWebKitAPI::GetDisplayMediaTest::promptForCapture): (TestWebKitAPI::TEST_F): (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]): Deleted. Canonical link: https://commits.webkit.org/261180@main

webkit-commit-queue · 2023-03-04T00:33:23Z

Committed 261180@main (fe99ba1): https://commits.webkit.org/261180@main

Reviewed commits have been landed. Closing PR #9789 and removing active labels.

eric-carlson requested a review from cdumez as a code owner February 8, 2023 01:00

eric-carlson self-assigned this Feb 8, 2023

eric-carlson added the WebRTC For bugs in WebRTC label Feb 8, 2023

eric-carlson marked this pull request as draft February 8, 2023 01:01

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 8, 2023

eric-carlson requested a review from youennf February 8, 2023 02:13

eric-carlson force-pushed the sc-content-picker-update branch from 6e7c917 to f8837f9 Compare February 8, 2023 02:21

eric-carlson force-pushed the sc-content-picker-update branch from f8837f9 to 74eff18 Compare February 8, 2023 02:59

eric-carlson force-pushed the sc-content-picker-update branch from 74eff18 to d52283d Compare February 8, 2023 18:08

eric-carlson force-pushed the sc-content-picker-update branch from d52283d to b88334d Compare February 8, 2023 21:05

jernoble approved these changes Feb 9, 2023

View reviewed changes

eric-carlson removed the merging-blocked Applied to prevent a change from being merged label Feb 24, 2023

eric-carlson force-pushed the sc-content-picker-update branch from b88334d to 309c521 Compare February 24, 2023 16:52

eric-carlson force-pushed the sc-content-picker-update branch from 309c521 to 5638682 Compare February 24, 2023 16:54

eric-carlson force-pushed the sc-content-picker-update branch from 5638682 to 14e91b9 Compare February 27, 2023 15:33

eric-carlson force-pushed the sc-content-picker-update branch from 14e91b9 to 40f5b24 Compare March 1, 2023 01:25

youennf reviewed Mar 1, 2023

View reviewed changes

cdumez reviewed Mar 1, 2023

View reviewed changes

Source/WebCore/platform/audio/PlatformMediaSessionManager.h Outdated Show resolved Hide resolved

Source/WebCore/platform/mediastream/DisplayCapturePromptType.h Outdated Show resolved Hide resolved

eric-carlson force-pushed the sc-content-picker-update branch from 40f5b24 to bcedbec Compare March 1, 2023 22:54

eric-carlson force-pushed the sc-content-picker-update branch from bcedbec to 60c27b8 Compare March 2, 2023 00:21

eric-carlson force-pushed the sc-content-picker-update branch from 60c27b8 to 1034d18 Compare March 2, 2023 19:31

eric-carlson force-pushed the sc-content-picker-update branch from 1034d18 to 62c864b Compare March 2, 2023 20:26

eric-carlson force-pushed the sc-content-picker-update branch from 62c864b to 876e55a Compare March 2, 2023 20:44

eric-carlson force-pushed the sc-content-picker-update branch from 876e55a to 5eb4f73 Compare March 3, 2023 15:30

eric-carlson marked this pull request as ready for review March 3, 2023 16:07

eric-carlson requested review from brentfulgham and pvollan as code owners March 3, 2023 16:07

eric-carlson force-pushed the sc-content-picker-update branch from 5eb4f73 to e37c1d9 Compare March 3, 2023 21:51

eric-carlson added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Mar 3, 2023

webkit-early-warning-system force-pushed the sc-content-picker-update branch from e37c1d9 to fe99ba1 Compare March 4, 2023 00:33

webkit-early-warning-system merged commit fe99ba1 into WebKit:main Mar 4, 2023

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 4, 2023

towe75 mentioned this pull request Apr 1, 2023

getDisplayMedia() has permission issue tauri-apps/tauri#2600

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cocoa] Use new screen/window picker API when available #9789

[Cocoa] Use new screen/window picker API when available #9789

eric-carlson commented Feb 8, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 24, 2023 •

edited

webkit-early-warning-system commented Feb 24, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Mar 1, 2023 •

edited

youennf Feb 24, 2023

eric-carlson Mar 1, 2023

youennf Mar 1, 2023

youennf Mar 1, 2023

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 3, 2023 •

edited

webkit-early-warning-system commented Mar 3, 2023 •

edited

webkit-commit-queue commented Mar 4, 2023

[Cocoa] Use new screen/window picker API when available #9789

[Cocoa] Use new screen/window picker API when available #9789

Conversation

eric-carlson commented Feb 8, 2023 • edited by webkit-early-warning-system

fe99ba1

webkit-early-warning-system commented Feb 8, 2023 • edited

webkit-early-warning-system commented Feb 8, 2023 • edited

webkit-early-warning-system commented Feb 8, 2023 • edited

webkit-early-warning-system commented Feb 8, 2023 • edited

webkit-early-warning-system commented Feb 8, 2023 • edited

webkit-early-warning-system commented Feb 24, 2023 • edited

webkit-early-warning-system commented Feb 24, 2023 • edited

webkit-early-warning-system commented Feb 27, 2023 • edited

webkit-early-warning-system commented Mar 1, 2023 • edited

youennf Feb 24, 2023

Choose a reason for hiding this comment

eric-carlson Mar 1, 2023

Choose a reason for hiding this comment

youennf Mar 1, 2023

Choose a reason for hiding this comment

youennf Mar 1, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Mar 1, 2023 • edited

webkit-early-warning-system commented Mar 2, 2023 • edited

webkit-early-warning-system commented Mar 2, 2023 • edited

webkit-early-warning-system commented Mar 2, 2023 • edited

webkit-early-warning-system commented Mar 2, 2023 • edited

webkit-early-warning-system commented Mar 3, 2023 • edited

webkit-early-warning-system commented Mar 3, 2023 • edited

webkit-commit-queue commented Mar 4, 2023

eric-carlson commented Feb 8, 2023 •

edited by webkit-early-warning-system

`fe99ba1`

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 8, 2023 •

edited

webkit-early-warning-system commented Feb 24, 2023 •

edited

webkit-early-warning-system commented Feb 24, 2023 •

edited

webkit-early-warning-system commented Feb 27, 2023 •

edited

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-early-warning-system commented Mar 1, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 2, 2023 •

edited

webkit-early-warning-system commented Mar 3, 2023 •

edited

webkit-early-warning-system commented Mar 3, 2023 •

edited