Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression(259893@main) imported/w3c/web-platform-tests/content-security-policy/reporting-api/reporting-api-works-on-frame-ancestors.https.sub.html is crashing #9793

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Regression(259893@main) imported/w3c/web-platform-tests/content-security-policy/reporting-api/reporting-api-works-on-frame-ancestors.https.sub.html is crashing #9793

merged 1 commit into from
Feb 8, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Feb 8, 2023 •
edited by webkit-early-warning-system

a172e77

Regression(259893@main) imported/w3c/web-platform-tests/content-security-policy/reporting-api/reporting-api-works-on-frame-ancestors.https.sub.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=251900
rdar://105129497

Reviewed by Alex Christensen.

CSPViolationReportBody is encoded as a non-null reference and thus should be
decoded as a Ref<CSPViolationReportBody>, not a RefPtr<CSPViolationReportBody>.

This was causing the decoded body to be null and we would crash when
dereferencing it later on.

* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<RefPtr<WebCore::ReportBody>>::decode):

Canonical link: https://commits.webkit.org/259993@main

65377e7

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Feb 8, 2023
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Feb 8, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash f264e92)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ⏳ 🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 65377e7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 added the merge-queue Applied to send a pull request to merge-queue label Feb 8, 2023
@cdumez @achristensen07
Regression(259893@main) imported/w3c/web-platform-tests/content-secur…
a172e77 
…ity-policy/reporting-api/reporting-api-works-on-frame-ancestors.https.sub.html is crashing

https://bugs.webkit.org/show_bug.cgi?id=251900
rdar://105129497

Reviewed by Alex Christensen.

CSPViolationReportBody is encoded as a non-null reference and thus should be
decoded as a Ref<CSPViolationReportBody>, not a RefPtr<CSPViolationReportBody>.

This was causing the decoded body to be null and we would crash when
dereferencing it later on.

* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<RefPtr<WebCore::ReportBody>>::decode):

Canonical link: https://commits.webkit.org/259993@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259993@main (a172e77): https://commits.webkit.org/259993@main

Reviewed commits have been landed. Closing PR #9793 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a172e77 into WebKit:main Feb 8, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achristensen07 achristensen07 achristensen07 approved these changes

@gavin-apple gavin-apple Awaiting requested review from gavin-apple

@smfr smfr Awaiting requested review from smfr

Assignees

@cdumez cdumez

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @achristensen07