New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web-animations] web-animations/interfaces/Animatable/animate-no-browsing-context.html is a unique failure #9872
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
graouts:animation-readiness-no-browsing-context
Feb 10, 2023
Merged
[web-animations] web-animations/interfaces/Animatable/animate-no-browsing-context.html is a unique failure #9872
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
graouts:animation-readiness-no-browsing-context
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorg
reviewed
Feb 9, 2023
grorg
approved these changes
Feb 9, 2023
graouts
force-pushed
the
animation-readiness-no-browsing-context
branch
from
February 9, 2023 17:33
a368fff
to
88dcbcd
Compare
EWS run on previous version of this PR (hash 88dcbcd)
|
graouts
force-pushed
the
animation-readiness-no-browsing-context
branch
from
February 9, 2023 17:36
88dcbcd
to
80e03dc
Compare
EWS run on current version of this PR (hash 80e03dc)
|
graouts
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 10, 2023
β¦sing-context.html is a unique failure https://bugs.webkit.org/show_bug.cgi?id=186494 rdar://problem/41000163 Reviewed by Dean Jackson. The Web Animations spec defines several factors for an animation to be considered "ready" [0], one being that the "user agent has completed any setup required to begin the playback of the animation's associated effect including rendering the first frame of any keyframe effect". While it does not specifically calls out the lack of a browsing context for the associated effect's target's document, there certainly won't be any frames rendered in that specific case. So we do not run pending tasks, the condition for the "ready" promise to resolve, if the associated effect is associated with a document lacking a browsing context. I filed a spec issue [1] to clarify this in the spec, but I believe the spirit of the spec already goes in the direction of this test. [0] https://drafts.csswg.org/web-animations-1/#ready [1] w3c/csswg-drafts#8439 * LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt: * Source/WebCore/animation/AnimationEffect.h: (WebCore::AnimationEffect::preventsAnimationReadiness const): * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::preventsAnimationReadiness const): * Source/WebCore/animation/KeyframeEffect.h: * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::tick): Canonical link: https://commits.webkit.org/260101@main
webkit-early-warning-system
force-pushed
the
animation-readiness-no-browsing-context
branch
from
February 10, 2023 06:42
80e03dc
to
87f47a6
Compare
Committed 260101@main (87f47a6): https://commits.webkit.org/260101@main Reviewed commits have been landed. Closing PR #9872 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
87f47a6
80e03dc