REGRESSION: sreality.cz: pinch zooming on maps causes tab to enter Tab Overview instead of interacting with map #9901

rr-codes · 2023-02-10T01:15:39Z

`887ab6d`

REGRESSION: sreality.cz: pinch zooming on maps causes tab to enter Tab Overview instead of interacting with map
https://bugs.webkit.org/show_bug.cgi?id=252023
rdar://104329203

Reviewed by Wenson Hsieh.

b7a998f introduced a new deferring gesture recognizer
for pan and pinch gestures. This had the conseequence of now letting Safari take
precedence over consuming these gestures rather than WebKit, causing the tab overview
to appear instead of zooming out of the map.

This PR adds a new private delegate method to `WKUIDelegate` that allows clients to specify
if a recognizer can be prevented by touch events. Then, if the gesture is also one that is
installed over the web view, the web view will take precedence.

* Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _gestureRecognizerCanBePreventedByTouchEvents:]):
(-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):

Canonical link: https://commits.webkit.org/260294@main

85bb734

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-10T01:18:51Z

EWS run on previous version of this PR (hash 131acda)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-10T21:40:51Z

EWS run on previous version of this PR (hash 8ec7db9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-02-11T03:29:49Z

EWS run on previous version of this PR (hash 1b8f0cc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	⏳ 🛠 jsc-mips
	❌ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-11T03:37:31Z

EWS run on previous version of this PR (hash d728e31)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

pxlcoder · 2023-02-11T20:46:12Z

Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

+    if (!uiDelegate)
+        return NO;


This check is unnecessary. If uiDelegate is nil, the respondsToSelector check below will fail.

The method could just return [uiDelegate respondsToSelector:@selector(_webView:gestureRecognizerCanBePreventedByTouchEvents:)] && [uiDelegate _webView:self.webView gestureRecognizerCanBePreventedByTouchEvents:gestureRecognizer].

webkit-early-warning-system · 2023-02-14T19:41:32Z

EWS run on previous version of this PR (hash c0f02f9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
	❌ 🛠 tv	✅ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
	❌ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 jsc-armv7-tests
	❌ 🛠 watch	✅ 🧪 mac-wk2-stress
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-02-14T19:41:33Z

EWS run on previous version of this PR (hash 8d7b745)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
	⏳ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🧪 gtk-wk2~~
	⏳ 🧪 api-ios	⏳ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
⏳ 🧪 services	⏳ 🛠 watch	⏳ 🧪 mac-wk2-stress	⏳ 🛠 jsc-mips
	~~🛠 watch-sim~~		⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-15T00:30:49Z

EWS run on current version of this PR (hash 85bb734)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

…b Overview instead of interacting with map https://bugs.webkit.org/show_bug.cgi?id=252023 rdar://104329203 Reviewed by Wenson Hsieh. WebKit@b7a998f introduced a new deferring gesture recognizer for pan and pinch gestures. This had the conseequence of now letting Safari take precedence over consuming these gestures rather than WebKit, causing the tab overview to appear instead of zooming out of the map. This PR adds a new private delegate method to `WKUIDelegate` that allows clients to specify if a recognizer can be prevented by touch events. Then, if the gesture is also one that is installed over the web view, the web view will take precedence. * Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _gestureRecognizerCanBePreventedByTouchEvents:]): (-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]): Canonical link: https://commits.webkit.org/260294@main

webkit-commit-queue · 2023-02-15T05:42:44Z

Committed 260294@main (887ab6d): https://commits.webkit.org/260294@main

Reviewed commits have been landed. Closing PR #9901 and removing active labels.

rr-codes requested a review from cdumez as a code owner February 10, 2023 01:15

rr-codes self-assigned this Feb 10, 2023

rr-codes added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Feb 10, 2023

rr-codes requested review from whsieh, pxlcoder, megangardner and hortont424 February 10, 2023 01:16

rr-codes force-pushed the eng/104329203 branch from 131acda to 8ec7db9 Compare February 10, 2023 21:38

rr-codes force-pushed the eng/104329203 branch from 8ec7db9 to 1b8f0cc Compare February 11, 2023 03:29

rr-codes force-pushed the eng/104329203 branch from 1b8f0cc to d728e31 Compare February 11, 2023 03:37

whsieh approved these changes Feb 11, 2023

View reviewed changes

pxlcoder reviewed Feb 11, 2023

View reviewed changes

rr-codes force-pushed the eng/104329203 branch 2 times, most recently from 8d7b745 to c0f02f9 Compare February 14, 2023 19:20

rr-codes force-pushed the eng/104329203 branch from c0f02f9 to 85bb734 Compare February 15, 2023 00:30

rr-codes added the merge-queue Applied to send a pull request to merge-queue label Feb 15, 2023

webkit-early-warning-system force-pushed the eng/104329203 branch from 85bb734 to 887ab6d Compare February 15, 2023 05:42

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 15, 2023

webkit-early-warning-system merged commit 887ab6d into WebKit:main Feb 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

REGRESSION: sreality.cz: pinch zooming on maps causes tab to enter Tab Overview instead of interacting with map #9901

REGRESSION: sreality.cz: pinch zooming on maps causes tab to enter Tab Overview instead of interacting with map #9901

rr-codes commented Feb 10, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 11, 2023 •

edited

webkit-early-warning-system commented Feb 11, 2023 •

edited

pxlcoder Feb 11, 2023

webkit-early-warning-system commented Feb 14, 2023 •

edited

webkit-early-warning-system commented Feb 14, 2023 •

edited

webkit-early-warning-system commented Feb 15, 2023 •

edited

webkit-commit-queue commented Feb 15, 2023

REGRESSION: sreality.cz: pinch zooming on maps causes tab to enter Tab Overview instead of interacting with map #9901

REGRESSION: sreality.cz: pinch zooming on maps causes tab to enter Tab Overview instead of interacting with map #9901

Conversation

rr-codes commented Feb 10, 2023 • edited by webkit-early-warning-system

887ab6d

webkit-early-warning-system commented Feb 10, 2023 • edited

webkit-early-warning-system commented Feb 10, 2023 • edited

webkit-early-warning-system commented Feb 11, 2023 • edited

webkit-early-warning-system commented Feb 11, 2023 • edited

pxlcoder Feb 11, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 14, 2023 • edited

webkit-early-warning-system commented Feb 14, 2023 • edited

webkit-early-warning-system commented Feb 15, 2023 • edited

webkit-commit-queue commented Feb 15, 2023

rr-codes commented Feb 10, 2023 •

edited by webkit-early-warning-system

`887ab6d`

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 11, 2023 •

edited

webkit-early-warning-system commented Feb 11, 2023 •

edited

webkit-early-warning-system commented Feb 14, 2023 •

edited

webkit-early-warning-system commented Feb 14, 2023 •

edited

webkit-early-warning-system commented Feb 15, 2023 •

edited