Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ macOS ] webanimations/accelerated-animation-slot-invalidation.html is a flaky image failure #9911

Merged
merged 1 commit into from Feb 10, 2023
Merged

[ macOS ] webanimations/accelerated-animation-slot-invalidation.html is a flaky image failure #9911

merged 1 commit into from Feb 10, 2023

Conversation

graouts
Copy link
Contributor

@graouts graouts commented Feb 10, 2023 •
edited by webkit-early-warning-system

d450764

[ macOS ] webanimations/accelerated-animation-slot-invalidation.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239791
rdar://problem/92360412

Reviewed by Antti Koivisto.

We need to wait an extra frame after the accelerated animation is committed for stable results.

* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:

Canonical link: https://commits.webkit.org/260109@main

146d7e7

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@graouts graouts self-assigned this Feb 10, 2023
@graouts graouts added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 146d7e7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@graouts graouts added Animations Bugs related to CSS + SVG animations and transitions unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed New Bugs Unclassified bugs are placed in this component until the correct component can be determined. labels Feb 10, 2023
@graouts
[ macOS ] webanimations/accelerated-animation-slot-invalidation.html …
d450764 
…is a flaky image failure

https://bugs.webkit.org/show_bug.cgi?id=239791
rdar://problem/92360412

Reviewed by Antti Koivisto.

We need to wait an extra frame after the accelerated animation is committed for stable results.

* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:

Canonical link: https://commits.webkit.org/260109@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the unflake-accelerated-animation-slot-invalidation branch from 146d7e7 to d450764 Compare February 10, 2023 15:13
@webkit-commit-queue
Copy link
Collaborator

Committed 260109@main (d450764): https://commits.webkit.org/260109@main

Reviewed commits have been landed. Closing PR #9911 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit d450764 into WebKit:main Feb 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 10, 2023
@graouts graouts deleted the unflake-accelerated-animation-slot-invalidation branch February 10, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttijk anttijk anttijk approved these changes

Assignees

@graouts graouts

Labels
Animations Bugs related to CSS + SVG animations and transitions
Projects
None yet
Milestone
No milestone
4 participants
@graouts @webkit-early-warning-system @webkit-commit-queue @anttijk