[CMake] DEBUG_FISSION is enabled for sccache clang builds #9912

philn · 2023-02-10T09:35:17Z

`55c9be4`

[CMake] DEBUG_FISSION is enabled for sccache clang builds
https://bugs.webkit.org/show_bug.cgi?id=252037

Reviewed by Michael Catanzaro.

Keep DEBUG_FISSION disabled for sccache clang release builds because it's not supported.

* Source/cmake/OptionsCommon.cmake:

Canonical link: https://commits.webkit.org/260444@main

5f50500

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🛠 jsc-armv7~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
✅ 🛠 🧪 merge	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-10T09:35:25Z

EWS run on previous version of this PR (hash d81eb60)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
~~🛠 🧪 jsc-arm64~~	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	✅ 🧪 mac-wk2-stress	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

philn · 2023-02-10T09:35:49Z

cc @calvaris

webkit-early-warning-system · 2023-02-10T09:44:19Z

EWS run on previous version of this PR (hash 3de316b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	⏳ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

calvaris · 2023-02-10T10:59:58Z

But sscache only fails with RELEASE, right? DEBUG worked properly, right? From what I see this disables fission also for debug builds that should work.

philn · 2023-02-10T11:43:11Z

Right, i'll update the patch.

webkit-early-warning-system · 2023-02-10T11:47:15Z

EWS run on previous version of this PR (hash 0caeb6f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
~~🛠 🧪 merge~~	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

calvaris · 2023-02-10T15:43:11Z

Right, i'll update the patch.

But please, check it really worked with debug or maybe it was something nobody used...

philn · 2023-02-10T16:40:18Z

I did!

philn · 2023-02-13T09:15:45Z

Ping :)

mcatanzaro · 2023-02-16T18:36:11Z

Source/cmake/OptionsCommon.cmake

@@ -159,6 +159,12 @@ if (CXX_COMPILER_SUPPORTS_GSPLIT_DWARF AND LD_SUPPORTS_SPLIT_DEBUG)
  set(ENABLE_DEBUG_FISSION_DEFAULT ON)
 endif ()

+if (ENABLE_DEBUG_FISSION_DEFAULT AND SCCACHE_FOUND AND COMPILER_IS_CLANG AND NOT CMAKE_BUILD_TYPE STREQUAL "Debug")


After some discussion, we decided to approve this if you test for RelWithDebInfo too:

Suggested change

if (ENABLE_DEBUG_FISSION_DEFAULT AND SCCACHE_FOUND AND COMPILER_IS_CLANG AND NOT CMAKE_BUILD_TYPE STREQUAL "Debug")

if (ENABLE_DEBUG_FISSION_DEFAULT AND SCCACHE_FOUND AND COMPILER_IS_CLANG AND NOT CMAKE_BUILD_TYPE STREQUAL "Debug" AND NOT CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")

RelWithDebInfo GTK clang sccache build passed. Thanks for the review!

webkit-early-warning-system · 2023-02-17T12:58:14Z

EWS run on current version of this PR (hash 5f50500)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🛠 jsc-armv7~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
✅ 🛠 🧪 merge	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

https://bugs.webkit.org/show_bug.cgi?id=252037 Reviewed by Michael Catanzaro. Keep DEBUG_FISSION disabled for sccache clang release builds because it's not supported. * Source/cmake/OptionsCommon.cmake: Canonical link: https://commits.webkit.org/260444@main

webkit-commit-queue · 2023-02-17T14:48:31Z

Committed 260444@main (55c9be4): https://commits.webkit.org/260444@main

Reviewed commits have been landed. Closing PR #9912 and removing active labels.

philn self-assigned this Feb 10, 2023

philn added the CMake Bugzilla component for CMake build system changes label Feb 10, 2023

philn requested a review from aperezdc February 10, 2023 09:35

philn marked this pull request as draft February 10, 2023 09:36

philn changed the title ~~[CMake] DEBUG_FISSION is enabled on non-debug builds~~ [CMake] DEBUG_FISSION is enabled for sccache clang builds Feb 10, 2023

philn force-pushed the eng/252037 branch from d81eb60 to 3de316b Compare February 10, 2023 09:44

philn marked this pull request as ready for review February 10, 2023 09:44

philn force-pushed the eng/252037 branch from 3de316b to 0caeb6f Compare February 10, 2023 11:46

philn requested a review from mcatanzaro February 15, 2023 16:35

mcatanzaro reviewed Feb 16, 2023

View reviewed changes

mcatanzaro approved these changes Feb 16, 2023

View reviewed changes

philn added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Feb 17, 2023

philn force-pushed the eng/252037 branch from 0caeb6f to 5f50500 Compare February 17, 2023 12:57

philn added the merge-queue Applied to send a pull request to merge-queue label Feb 17, 2023

webkit-early-warning-system force-pushed the eng/252037 branch from 5f50500 to 55c9be4 Compare February 17, 2023 14:48

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 17, 2023

webkit-early-warning-system merged commit 55c9be4 into WebKit:main Feb 17, 2023

philn deleted the eng/252037 branch February 17, 2023 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CMake] DEBUG_FISSION is enabled for sccache clang builds #9912

[CMake] DEBUG_FISSION is enabled for sccache clang builds #9912

philn commented Feb 10, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 10, 2023 •

edited

philn commented Feb 10, 2023

webkit-early-warning-system commented Feb 10, 2023 •

edited

calvaris commented Feb 10, 2023

philn commented Feb 10, 2023

webkit-early-warning-system commented Feb 10, 2023 •

edited

calvaris commented Feb 10, 2023

philn commented Feb 10, 2023

philn commented Feb 13, 2023

mcatanzaro Feb 16, 2023

philn Feb 17, 2023

webkit-early-warning-system commented Feb 17, 2023 •

edited

webkit-commit-queue commented Feb 17, 2023

	if (ENABLE_DEBUG_FISSION_DEFAULT AND SCCACHE_FOUND AND COMPILER_IS_CLANG AND NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
	if (ENABLE_DEBUG_FISSION_DEFAULT AND SCCACHE_FOUND AND COMPILER_IS_CLANG AND NOT CMAKE_BUILD_TYPE STREQUAL "Debug" AND NOT CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")

[CMake] DEBUG_FISSION is enabled for sccache clang builds #9912

[CMake] DEBUG_FISSION is enabled for sccache clang builds #9912

Conversation

philn commented Feb 10, 2023 • edited by webkit-early-warning-system

55c9be4

webkit-early-warning-system commented Feb 10, 2023 • edited

philn commented Feb 10, 2023

webkit-early-warning-system commented Feb 10, 2023 • edited

calvaris commented Feb 10, 2023

philn commented Feb 10, 2023

webkit-early-warning-system commented Feb 10, 2023 • edited

calvaris commented Feb 10, 2023

philn commented Feb 10, 2023

philn commented Feb 13, 2023

mcatanzaro Feb 16, 2023

Choose a reason for hiding this comment

philn Feb 17, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 17, 2023 • edited

webkit-commit-queue commented Feb 17, 2023

philn commented Feb 10, 2023 •

edited by webkit-early-warning-system

`55c9be4`

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 10, 2023 •

edited

webkit-early-warning-system commented Feb 17, 2023 •

edited