[JSC] Sort opcodes to remove padding from metadata table #9927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeuzagallo
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash 05710ee) |
Constellation
approved these changes
Feb 10, 2023
Comment on lines
35
to
40
| #define JSC_ALIGNMENT_CHECK(size) static_assert(size <= UnlinkedMetadataTable::s_maxMetadataAlignment); | ||
| static_assert((UnlinkedMetadataTable::s_maxMetadataAlignment >= | ||
| #define JSC_ALIGNMENT_CHECK(size) size) && (size >= | ||
| FOR_EACH_BYTECODE_METADATA_ALIGNMENT(JSC_ALIGNMENT_CHECK) | ||
| #undef JSC_ALIGNMENT_CHECK | ||
| 1)); |
There was a problem hiding this comment.
Looks like GCC is not happy with this
There was a problem hiding this comment.
Yeah, it's probably because when computing the order I assumed that pointers were 8-byte aligned. I might just skip both new assertions on 32-bit since we will still align if necessary.
tadeuzagallo
force-pushed
the
eng/JSC-Sort-opcodes-to-remove-padding-from-metadata-table
branch
from
05710ee
to
4b30616
Compare
|
EWS run on current version of this PR (hash 4b30616) |
https://bugs.webkit.org/show_bug.cgi?id=252055 rdar://105276503 Reviewed by Yusuke Suzuki. Sort the opcodes by metadata alignment requirements. We start with 8-byte aligned, followed by 4-byte, etc. The memory savings are minimal (too small to measure with confidence), but they are also free. * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.cpp: (JSC::UnlinkedMetadataTable::finalize): Canonical link: https://commits.webkit.org/260193@main
webkit-commit-queue
force-pushed
the
eng/JSC-Sort-opcodes-to-remove-padding-from-metadata-table
branch
from
4b30616
to
e2606b1
Compare
|
Committed 260193@main (e2606b1): https://commits.webkit.org/260193@main Reviewed commits have been landed. Closing PR #9927 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
tadeuzagallo
deleted the
eng/JSC-Sort-opcodes-to-remove-padding-from-metadata-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2606b1
4b30616
🧪 ios-wk2🧪 mac-AS-debug-wk2🧪 jsc-armv7-tests