Remove Apple Win Support from WTF #9933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwrt
added
the
WebCore Misc.
|
EWS run on previous version of this PR (hash c61dec6) |
brentfulgham
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
We will also be able to remove the OS(WINDOWS)/PLATFORM(WIN) bits from cf/FileSystemCF.cpp and cf/URLCF.cpp, but I believe WinCairo is still building some of this in support of the WebKitLegacy code (which will go away soon). So I think we should hold off on removing those until Don tell us they are ready.
stwrt
force-pushed
the
eng/delete_win_port_from_wtf
branch
from
c61dec6
to
6d3f382
Compare
|
EWS run on current version of this PR (hash 6d3f382) |
donny-dont
approved these changes
Feb 10, 2023
|
Just waiting for the Win Cairo CI to wrap up before landing. |
https://bugs.webkit.org/show_bug.cgi?id=252061 Reviewed by Don Olmstead and Brent Fulgham. Remove Apple Win Support from WTF as it is no longer in use. This should not touch the WIN CAIRO build at all. * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/CMakeLists.txt: * Source/WTF/wtf/PlatformEnable.h: * Source/WTF/wtf/PlatformEnableWinApple.h: Removed. Canonical link: https://commits.webkit.org/260137@main
webkit-early-warning-system
force-pushed
the
eng/delete_win_port_from_wtf
branch
from
6d3f382
to
4ad56ab
Compare
|
Committed 260137@main (4ad56ab): https://commits.webkit.org/260137@main Reviewed commits have been landed. Closing PR #9933 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4ad56ab
6d3f382
🛠 mac-AS-debug🧪 api-gtk🛠 🧪 jsc🛠 jsc-armv7🧪 mac-AS-debug-wk2🧪 jsc-armv7-tests