[JSC] Vector operations should work with CSE #9979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash 240c2d3) |
Constellation
force-pushed
the
eng/JSC-Vector-operations-should-work-with-CSE
branch
from
240c2d3
to
0ca1e20
Compare
|
EWS run on previous version of this PR (hash 0ca1e20) |
Constellation
force-pushed
the
eng/JSC-Vector-operations-should-work-with-CSE
branch
from
0ca1e20
to
7a46965
Compare
|
EWS run on previous version of this PR (hash 7a46965) |
Constellation
force-pushed
the
eng/JSC-Vector-operations-should-work-with-CSE
branch
from
7a46965
to
9846b4f
Compare
|
EWS run on previous version of this PR (hash 9846b4f) |
kmiller68
approved these changes
Feb 13, 2023
|
Added assertions for them. |
Constellation
force-pushed
the
eng/JSC-Vector-operations-should-work-with-CSE
branch
from
9846b4f
to
4bfb374
Compare
|
EWS run on current version of this PR (hash 4bfb374) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=252114 rdar://105334819 Reviewed by Keith Miller. This patch integrates Vector operations into B3 CSE by defining Value::key and ValueKey for them. We also clean up some vector related code for generating code. * Source/JavaScriptCore/b3/B3LowerToAir.cpp: * Source/JavaScriptCore/b3/B3SIMDValue.h: * Source/JavaScriptCore/b3/B3Value.cpp: (JSC::B3::Value::key const): * Source/JavaScriptCore/b3/B3Value.h: * Source/JavaScriptCore/b3/B3ValueKey.cpp: (JSC::B3::ValueKey::materialize const): * Source/JavaScriptCore/b3/B3ValueKey.h: (JSC::B3::ValueKey::simdInfo const): (JSC::B3::ValueKey::operator== const): * Source/JavaScriptCore/b3/B3ValueKeyInlines.h: (JSC::B3::ValueKey::ValueKey): * Source/JavaScriptCore/jit/SIMDInfo.h: (JSC::SIMDInfo::operator==): (JSC::SIMDInfo::operator!=): Canonical link: https://commits.webkit.org/260223@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Vector-operations-should-work-with-CSE
branch
from
4bfb374
to
151366f
Compare
|
Committed 260223@main (151366f): https://commits.webkit.org/260223@main Reviewed commits have been landed. Closing PR #9979 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Constellation
deleted the
eng/JSC-Vector-operations-should-work-with-CSE
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
151366f
4bfb374
🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 🧪 jsc🛠 tv🧪 mac-wk2🛠 jsc-armv7🧪 mac-AS-debug-wk2🧪 jsc-armv7-tests🛠 watch🧪 mac-wk2-stress🛠 jsc-mips🧪 jsc-mips-tests