Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

innerHTML fast parser should leverage the same attribute value cache as the full HTML parser #9981

Merged
merged 1 commit into from
Feb 12, 2023
Merged

innerHTML fast parser should leverage the same attribute value cache as the full HTML parser #9981

merged 1 commit into from
Feb 12, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Feb 11, 2023 •
edited by webkit-early-warning-system

153929d

innerHTML fast parser should leverage the same attribute value cache as the full HTML parser
https://bugs.webkit.org/show_bug.cgi?id=252116

Reviewed by Darin Adler.

innerHTML fast parser should leverage the same attribute value cache as the full
HTML parser. This may be a ~0.3% progression on Speedometer.

* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::processAttribute):
* Source/WebCore/html/parser/HTMLNameCache.h:
(WebCore::HTMLNameCache::makeAttributeValue):
(WebCore::HTMLNameCache::makeAtomString):

Canonical link: https://commits.webkit.org/260165@main

8a267d3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez cdumez self-assigned this Feb 11, 2023
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Feb 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 8374d29)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style   🛠 ios   🛠 mac   🛠 wpe ⏳ 🛠 wincairo
  🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🛠 gtk
  🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
❌ 🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv   🧪 mac-wk2 ⏳ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2 ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch   🧪 mac-wk2-stress ⏳ 🛠 jsc-mips
⏳ 🛠 watch-sim ⏳ 🧪 jsc-mips-tests

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 8a267d3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez cdumez marked this pull request as ready for review February 11, 2023 23:48
@cdumez cdumez requested a review from rniwa as a code owner February 11, 2023 23:48
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 12, 2023
@cdumez
innerHTML fast parser should leverage the same attribute value cache …
153929d 
…as the full HTML parser

https://bugs.webkit.org/show_bug.cgi?id=252116

Reviewed by Darin Adler.

innerHTML fast parser should leverage the same attribute value cache as the full
HTML parser. This may be a ~0.3% progression on Speedometer.

* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::processAttribute):
* Source/WebCore/html/parser/HTMLNameCache.h:
(WebCore::HTMLNameCache::makeAttributeValue):
(WebCore::HTMLNameCache::makeAtomString):

Canonical link: https://commits.webkit.org/260165@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260165@main (153929d): https://commits.webkit.org/260165@main

Reviewed commits have been landed. Closing PR #9981 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 153929d into WebKit:main Feb 12, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@heycam heycam Awaiting requested review from heycam

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@cdumez cdumez

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler