Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Use VectorLoadXSplat in B3 #9984

Merged
merged 1 commit into from
Feb 13, 2023
Merged

[JSC] Use VectorLoadXSplat in B3 #9984

merged 1 commit into from
Feb 13, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Feb 11, 2023 •
edited by webkit-early-warning-system

44bf338

[JSC] Use VectorLoadXSplat in B3
https://bugs.webkit.org/show_bug.cgi?id=252120
rdar://105341630

Reviewed by Keith Miller.

This patch uses VectorLoadXSplat for VectorSplat(LoadX) pattern.
For SIMDLoadSplat wasm opcodes, we are emitting VectorSplat(LoadX) in B3.
But we were not successfully converting it to VectorLoadXSplat for Air.
This patch adds lowering for them so that we emit VectorLoadXSplat.

* Source/JavaScriptCore/b3/B3LowerToAir.cpp:

Canonical link: https://commits.webkit.org/260206@main

a64faa8

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

@Constellation Constellation requested a review from a team as a code owner February 11, 2023 23:36
@Constellation Constellation self-assigned this Feb 11, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Feb 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a64faa8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

kmiller68
kmiller68 approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 13, 2023
@Constellation
[JSC] Use VectorLoadXSplat in B3
44bf338 
https://bugs.webkit.org/show_bug.cgi?id=252120
rdar://105341630

Reviewed by Keith Miller.

This patch uses VectorLoadXSplat for VectorSplat(LoadX) pattern.
For SIMDLoadSplat wasm opcodes, we are emitting VectorSplat(LoadX) in B3.
But we were not successfully converting it to VectorLoadXSplat for Air.
This patch adds lowering for them so that we emit VectorLoadXSplat.

* Source/JavaScriptCore/b3/B3LowerToAir.cpp:

Canonical link: https://commits.webkit.org/260206@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260206@main (44bf338): https://commits.webkit.org/260206@main

Reviewed commits have been landed. Closing PR #9984 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 44bf338 into WebKit:main Feb 13, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 13, 2023
@Constellation Constellation deleted the eng/JSC-Use-VectorLoadXSplat-in-B3 branch February 14, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmiller68 kmiller68 kmiller68 approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @kmiller68