Implement text-spacing-trim parser for auto and space-all #9988

vitorroriz · 2023-02-12T01:02:48Z

`4cee70d`

Implement text-spacing-trim parser for auto and space-all
https://bugs.webkit.org/show_bug.cgi?id=252124
rdar://105342875

Reference: w3c/csswg-drafts#4246 (comment)

Implement a partial parser for text-spacing-trim (text-spacing longhand)
for auto and space-all values. We can then iterate from here adding
the remaining values once we commit to handle them.

Syntax:
text-spacing-trim: auto | space-all

Reviewed by Myles C. Maxfield.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::textSpacingTrimFromStyle):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::initialValueForLonghand):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeTextSpacingTrim):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/platform/text/TextSpacing.h: Added.
(WebCore::TextSpacingTrim::isAuto const):
(WebCore::TextSpacingTrim::isSpaceAll const):
(WebCore::TextSpacingTrim::operator== const):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::textSpacingTrim const):
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setTextSpacingTrim):
(WebCore::RenderStyle::initialTextSpacingTrim):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTextSpacingTrim):

Canonical link: https://commits.webkit.org/260288@main

22c8777

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🛠 jsc-armv7~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	~~🧪 jsc-armv7-tests~~
	~~🛠 watch~~	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
✅ 🛠 🧪 merge	✅ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2023-02-12T01:03:09Z

EWS run on previous version of this PR (hash c33337d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 mac-wk1	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk2~~	⏳ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~	⏳ 🛠 jsc-mips
	✅ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-12T01:06:31Z

EWS run on previous version of this PR (hash 6245932)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-12T16:29:42Z

EWS run on previous version of this PR (hash 3548da0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 mac-wk1~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

graouts · 2023-02-12T18:08:06Z

Source/WebCore/animation/CSSPropertyAnimation.cpp

@@ -3492,6 +3493,7 @@ CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap()
        new DiscretePropertyWrapper<WhiteSpace>(CSSPropertyWhiteSpace, &RenderStyle::whiteSpace, &RenderStyle::setWhiteSpace),
        new DiscretePropertyWrapper<WordBreak>(CSSPropertyWordBreak, &RenderStyle::wordBreak, &RenderStyle::setWordBreak),
        new DiscretePropertyWrapper<OverflowAnchor>(CSSPropertyOverflowAnchor, &RenderStyle::overflowAnchor, &RenderStyle::setOverflowAnchor),
+        new DiscretePropertyWrapper<TextSpacingTrim>(CSSPropertyTextSpacingTrim, &RenderStyle::textSpacingTrim, &RenderStyle::setTextSpacingTrim),


It doesn't look like there is testing coverage for this. Could you add the appropriate entry to web-animations/animation-model/animation-types/property-list.js? Should be something like this:

'text-spacing-trim': { // https://drafts.csswg.org/link-to-spec types: [ { type: 'discrete' , options: [ [ 'space-all', 'trim-all' ] ] } ] },

You can feel free to expand on that of course.

Fixed, thanks.

graouts · 2023-02-12T18:08:16Z

Source/WebCore/css/CSSProperties.json

+                "settings-flag": "cssTextSpacingEnabled",
+                "converter": "TextSpacingTrim",
+                "parser-function": "consumeTextSpacingTrim",
+                "parser-grammar-unused": "auto | space-all |  trim-all | [ allow-end || space-first ]",


Extra space before trim-all.

graouts · 2023-02-12T18:08:59Z

Source/WebCore/rendering/style/RenderStyle.cpp

-        if (existingValue && existingValue->equals(value.get()))
-            return;
-        data.access().customProperties.access().setCustomPropertyValue(name, WTFMove(value));
+    if (existingValue && existingValue->equals(value.get()))
+        return;
+    data.access().customProperties.access().setCustomPropertyValue(name, WTFMove(value));


That change looks wrong.

Agreed, this change looks wrong

webkit-early-warning-system · 2023-02-12T18:40:24Z

EWS run on previous version of this PR (hash a064194)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-12T22:21:37Z

EWS run on previous version of this PR (hash 56e9c7a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

graouts · 2023-02-13T07:22:11Z

You need to export those changes to the WPT repository. You can automate that using export-w3c-test-changes.

vitorroriz · 2023-02-13T08:38:28Z

You need to export those changes to the WPT repository. You can automate that using export-w3c-test-changes.

We don't want to do that yet. The spec is in flux and we are implementing partially based on the CSSWG resolution not yet converted into the draft.

litherum · 2023-02-14T19:27:37Z

Source/WebCore/css/ComputedStyleExtractor.cpp

+    if (textSpacingTrim.isAuto())
+        return CSSPrimitiveValue::create(CSSValueAuto);
+
+    return CSSPrimitiveValue::create(CSSValueSpaceAll);


maybe ASSERT() here?

litherum · 2023-02-14T19:28:09Z

Source/WebCore/platform/text/TextSpacing.cpp

+
+namespace WebCore {
+
+WTF::TextStream& operator<<(WTF::TextStream& ts, const TextSpacingTrim& value)


Do we really need a whole file just for this? Don't we have somewhere else that has a whole bunch of these?

litherum · 2023-02-14T19:28:41Z

Source/WebCore/rendering/style/RenderStyle.cpp

-        if (existingValue && existingValue->equals(value.get()))
-            return;
-        data.access().customProperties.access().setCustomPropertyValue(name, WTFMove(value));
+    if (existingValue && existingValue->equals(value.get()))
+        return;
+    data.access().customProperties.access().setCustomPropertyValue(name, WTFMove(value));


Agreed, this change looks wrong

webkit-early-warning-system · 2023-02-14T22:20:07Z

EWS run on previous version of this PR (hash e5aa462)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🛠 gtk
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 gtk-wk2
	⏳ 🧪 api-ios	❌ 🧪 mac-wk1	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk2	⏳ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64	~~🛠 tv-sim~~	❌ 🧪 mac-AS-debug-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	❌ 🧪 mac-wk2-stress	⏳ 🛠 jsc-mips
	❌ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-02-14T22:41:28Z

EWS run on current version of this PR (hash 22c8777)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🛠 jsc-armv7~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~	~~🧪 jsc-armv7-tests~~
	~~🛠 watch~~	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
✅ 🛠 🧪 merge	✅ 🛠 watch-sim		~~🧪 jsc-mips-tests~~

https://bugs.webkit.org/show_bug.cgi?id=252124 rdar://105342875 Reference: w3c/csswg-drafts#4246 (comment) Implement a partial parser for text-spacing-trim (text-spacing longhand) for auto and space-all values. We can then iterate from here adding the remaining values once we commit to handle them. Syntax: text-spacing-trim: auto | space-all Reviewed by Myles C. Maxfield. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Headers.cmake: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::textSpacingTrimFromStyle): (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::initialValueForLonghand): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeTextSpacingTrim): * Source/WebCore/css/parser/CSSPropertyParserHelpers.h: * Source/WebCore/platform/text/TextSpacing.h: Added. (WebCore::TextSpacingTrim::isAuto const): (WebCore::TextSpacingTrim::isSpaceAll const): (WebCore::TextSpacingTrim::operator== const): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::textSpacingTrim const): * Source/WebCore/rendering/style/RenderStyle.h: (WebCore::RenderStyle::setTextSpacingTrim): (WebCore::RenderStyle::initialTextSpacingTrim): * Source/WebCore/rendering/style/RenderStyleConstants.cpp: (WebCore::operator<<): * Source/WebCore/rendering/style/RenderStyleConstants.h: * Source/WebCore/rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * Source/WebCore/rendering/style/StyleRareInheritedData.h: * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertTextSpacingTrim): Canonical link: https://commits.webkit.org/260288@main

webkit-commit-queue · 2023-02-15T01:24:46Z

Committed 260288@main (4cee70d): https://commits.webkit.org/260288@main

Reviewed commits have been landed. Closing PR #9988 and removing active labels.

vitorroriz self-assigned this Feb 12, 2023

vitorroriz added the CSS Cascading Style Sheets implementation label Feb 12, 2023

vitorroriz force-pushed the text-spacing-trim-auto branch from c33337d to 6245932 Compare February 12, 2023 01:06

vitorroriz changed the title ~~Need a short description (OOPS!).~~ Implement text-spacing-trim parser for auto and space-all Feb 12, 2023

vitorroriz requested a review from nt1m February 12, 2023 01:08

vitorroriz force-pushed the text-spacing-trim-auto branch from 6245932 to 3548da0 Compare February 12, 2023 16:29

vitorroriz requested a review from graouts as a code owner February 12, 2023 16:29

graouts reviewed Feb 12, 2023

View reviewed changes

vitorroriz force-pushed the text-spacing-trim-auto branch from 3548da0 to a064194 Compare February 12, 2023 18:39

vitorroriz force-pushed the text-spacing-trim-auto branch from a064194 to 56e9c7a Compare February 12, 2023 22:15

litherum approved these changes Feb 14, 2023

View reviewed changes

vitorroriz force-pushed the text-spacing-trim-auto branch from 56e9c7a to e5aa462 Compare February 14, 2023 22:06

vitorroriz force-pushed the text-spacing-trim-auto branch from e5aa462 to 22c8777 Compare February 14, 2023 22:37

vitorroriz added the merge-queue Applied to send a pull request to merge-queue label Feb 15, 2023

webkit-early-warning-system force-pushed the text-spacing-trim-auto branch from 22c8777 to 4cee70d Compare February 15, 2023 01:24

webkit-early-warning-system merged commit 4cee70d into WebKit:main Feb 15, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement text-spacing-trim parser for auto and space-all #9988

Implement text-spacing-trim parser for auto and space-all #9988

vitorroriz commented Feb 12, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 12, 2023 •

edited

webkit-early-warning-system commented Feb 12, 2023 •

edited

webkit-early-warning-system commented Feb 12, 2023 •

edited

graouts Feb 12, 2023

vitorroriz Feb 13, 2023

graouts Feb 12, 2023

graouts Feb 12, 2023

litherum Feb 14, 2023

webkit-early-warning-system commented Feb 12, 2023 •

edited

webkit-early-warning-system commented Feb 12, 2023 •

edited

graouts commented Feb 13, 2023

vitorroriz commented Feb 13, 2023

litherum Feb 14, 2023

litherum Feb 14, 2023

litherum Feb 14, 2023

webkit-early-warning-system commented Feb 14, 2023 •

edited

webkit-early-warning-system commented Feb 14, 2023 •

edited

webkit-commit-queue commented Feb 15, 2023


		namespace WebCore {

		WTF::TextStream& operator<<(WTF::TextStream& ts, const TextSpacingTrim& value)

Implement text-spacing-trim parser for auto and space-all #9988

Implement text-spacing-trim parser for auto and space-all #9988

Conversation

vitorroriz commented Feb 12, 2023 • edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 12, 2023 • edited

webkit-early-warning-system commented Feb 12, 2023 • edited

webkit-early-warning-system commented Feb 12, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 12, 2023 • edited

webkit-early-warning-system commented Feb 12, 2023 • edited

graouts commented Feb 13, 2023

vitorroriz commented Feb 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Feb 14, 2023 • edited

webkit-early-warning-system commented Feb 14, 2023 • edited

webkit-commit-queue commented Feb 15, 2023

vitorroriz commented Feb 12, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Feb 12, 2023 •

edited

webkit-early-warning-system commented Feb 12, 2023 •

edited

webkit-early-warning-system commented Feb 12, 2023 •

edited

webkit-early-warning-system commented Feb 12, 2023 •

edited

webkit-early-warning-system commented Feb 12, 2023 •

edited

webkit-early-warning-system commented Feb 14, 2023 •

edited

webkit-early-warning-system commented Feb 14, 2023 •

edited