-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ANGLE to 2022-05-24 (8291f2d3e72eca3a25826b689a013c292ef4ba94) #999
Update ANGLE to 2022-05-24 (8291f2d3e72eca3a25826b689a013c292ef4ba94) #999
Conversation
Please note that the style failures are expected; the compiled shaders in ANGLE's D3D backend have Windows line endings. We don't want to change these from upstream, as doing so introduces merge conflicts during every ANGLE update into WebKit. |
Note also that Kyle points out he has another critical bug fix incoming in https://bugs.webkit.org/show_bug.cgi?id=240896 , so maybe I should redo this roll after he's landed that. |
cc @greggman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to merge even with the style errors
We're going to deliberately bypass the style check, as changing the line endings in the noted files is problematic for future ANGLE rolls, and the test failure on win is unrelated. Landing. |
Not clear to me whether the merge-queue label had no effect because of the style failures we've agreed we want to bypass, and the only layout test failure is unrelated. Adding unsafe-merge-queue. |
04ea6a3
to
ea0448d
Compare
Committed r294834 (250984@main): https://commits.webkit.org/250984@main Reviewed commits have been landed. Closing PR #999 and removing active labels. |
…i/wpe-2.38/add_did-start-provisional-data-load-for-frame_signal Add "did-start-provisional-load-for-frame" signal
ea0448d