Ignore <option> element while building accessibility tree when <select> is hidden

[obyknovenius]

a9c99d1

Ignore <option> element while building accessibility tree when <select> is hidden
https://bugs.webkit.org/show_bug.cgi?id=245578

Reviewed by Carlos Garcia Campos.

When we insert `AccessibilityObject`'s child, we check that its
`parentObject` is the `AccessiblityObject` we're inserting it into.

In normal circumstances `AccessibilityObject`'s subclass representing
`HTMLSelectElement` is `AccessibilityMenuList`. It creates
`AccessiblityMenuListPopup` as its only accessibility child. All
`HTMLSelectElement`'s node children accessibility objects are inserted
into the popup.

For non-multiple `HTMLSelectElement` the only possible node child class
that participates in accessibility tree is `HTMLOptionElement` with its
accessibility counterpart `AccessibilityMenuListOption`.
`AccessibilityMenuListOption`'s `parentObject` is set explicitly to
`AccessiblityMenuListPopup` when it's being inserted into one.

Situation changes when `HTMLSelectElement` is hidden but `aria-hidden`
attribute set to `false`
(like in `accessibility/aria-visible-element-roles.html` layout test).
In this case, we don't have a renderer object associated with
`HTMLSelectElement` and simply create a regular `AccessiblityNodeObject`
for it. Then we insert `AccessibilityMenuListOption` as
`AccessiblityNodeObject`'s child without setting its `parentObject`.
Thus, `child->parentObject() == this` assertion fails.

Since we can't present a menu without `HTMLSelectElement`'s renderer
anyway (and this is what Chromium does), it's safe to skip
`HTMLSelectElement` while building the accessibility tree in such cases.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):

Canonical link: https://commits.webkit.org/254970@main

624bac7

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[webkit-early-warning-system]

EWS run on previous version of this PR (hash e044941)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[carlosgcampos]

Please, mention the commit message what this is fixing. I think it's an assert in a particular test, right? Does it happen in any platform? because the change is in cross-platform code.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 5404306)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[obyknovenius]

Please, mention the commit message what this is fixing. I think it's an assert in a particular test, right? Does it happen in any platform? because the change is in cross-platform code.

I've updated the commit message. How do I update the PR description?

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 88e86ac)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

[obyknovenius]

I found out that there is a platform-specific hook for this purpose in AccessibilityObject. Made this PR AT-SPI specific and reused the solution from mac.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 0ae0c1e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[webkit-early-warning-system]

EWS run on current version of this PR (hash 624bac7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[carlosgcampos]

This looks good to me.

[webkit-commit-queue]

Committed 254970@main (a9c99d1): https://commits.webkit.org/254970@main

Reviewed commits have been landed. Closing PR #4630 and removing active labels.