Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse <img srcset="..."> attribute properly #26

Open
Treora opened this issue Jul 23, 2018 · 0 comments
Open

Parse <img srcset="..."> attribute properly #26

Treora opened this issue Jul 23, 2018 · 0 comments
Labels
snapshot quality Improving fidelity/size/durability/etc of the output

Comments

@Treora
Copy link
Contributor

Treora commented Jul 23, 2018

We currently split by comma, but that is a too simplistic approach. Especially as we use data URLs ourselves, which always contain a comma, we shoot ourselves in the foot when snapshotting a snapshot (related: #13).

The better parsing algorithm has been spec'd by whatwg, and implemented by albell.

We could try fix the srcset npm package while at it (see issue).
@Treora Treora added the snapshot quality Improving fidelity/size/durability/etc of the output label Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
snapshot quality Improving fidelity/size/durability/etc of the output
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Treora