feat: multisig join --group arg #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,7 +201,12 @@ def incept(self, attrs): | |||
|
|
|||
| if approve: | |||
| if self.auto: | |||
| alias = "test alias" | |||
| alias = self.alias | |||
There was a problem hiding this comment.
This does not account for auto being true and alias being None which will cause an exception below. (As happened in the scripts run for this PR).
There was a problem hiding this comment.
This was changed in the most recent commit to have a nested if statement checking of the alias (now "group") is set.
For example:
if self.auto:
if self.group is None:
group = "default-group"
else:
group = self.group| @@ -196,7 +201,12 @@ def incept(self, attrs): | |||
|
|
|||
| if approve: | |||
| if self.auto: | |||
| alias = "test alias" | |||
| alias = self.alias | |||
| elif self.alias: | |||
There was a problem hiding this comment.
self.alias should only be used if self.auto is True.
There was a problem hiding this comment.
This was changed in the most recent commit to have a nested if statement checking of the alias (now "group") is set.
For example:
if self.auto:
if self.group is None:
group = "default-group"
else:
group = self.group
pfeairheller
requested changes
May 14, 2024
|
I changed the argument name from |
kentbull
changed the title
pfeairheller
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the capability to specify an alias during multisig join. Previously the alias was always set to "test alias" which would cause alias collision problems when doing successive multisig join commands for different identifiers.