Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for Multisig delegated vLEI issuance (QVI, LE, ECR) #207

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

nkongsuwan
Copy link
Contributor

@nkongsuwan nkongsuwan commented Jan 26, 2024

Add an integration test for multi-signature delegated issuance of QVI, LE, and ECR vLEI credentials:

  • The script simulates the process described in the vLEI EGF where QVI has 3 QARs and LE has 3 LARs.
  • Here, GLEIF has 2 GARs that form a GEDA and delegate to the QVI AID. (Technically, the GEDA has 5 External GARs, but the test will get too long with 5 GARs.)
  • The ECR credential is issued directly from the LE.

[Edit 18 Feb]: the three problems below seem to have been resolved.
Currently, there are two problems, one major and one minor:

@nkongsuwan nkongsuwan marked this pull request as draft January 26, 2024 13:58
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (a49db7f) to head (09030c9).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #207   +/-   ##
============================================
  Coverage        82.85%   82.85%           
============================================
  Files               47       47           
  Lines             4200     4200           
  Branches          1046     1046           
============================================
  Hits              3480     3480           
  Misses             691      691           
  Partials            29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkongsuwan nkongsuwan force-pushed the multisig-vlei-test branch 3 times, most recently from fe67ee6 to c4ff292 Compare February 18, 2024 12:52
@nkongsuwan nkongsuwan force-pushed the multisig-vlei-test branch 2 times, most recently from 947f16f to 0468df0 Compare February 18, 2024 14:41
@nkongsuwan nkongsuwan marked this pull request as ready for review February 20, 2024 13:13
@nkongsuwan
Copy link
Contributor Author

This PR is completed, but it is based on the recent change in PR #222, which hasn't yet been merged.

@seriouscoderone
Copy link

Why not use const?

@pfeairheller
Copy link
Member

PR #222 has been merged so a rebase here should get this build working.

Signed-off-by: Nuttawut Kongsuwan <win@finema.co>
Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Only thing is that test time increases significantly, I suppose there is now some overlap in this test and the multisig.test.ts file that can be addressed later.

@lenkan lenkan merged commit 65d5b83 into WebOfTrust:development Apr 5, 2024
8 checks passed
daviddm pushed a commit to daviddm/signify-ts that referenced this pull request May 8, 2024
Signed-off-by: Nuttawut Kongsuwan <win@finema.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants