-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test for Multisig delegated vLEI issuance (QVI, LE, ECR) #207
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #207 +/- ##
============================================
Coverage 82.85% 82.85%
============================================
Files 47 47
Lines 4200 4200
Branches 1046 1046
============================================
Hits 3480 3480
Misses 691 691
Partials 29 29 ☔ View full report in Codecov by Sentry. |
fe67ee6
to
c4ff292
Compare
947f16f
to
0468df0
Compare
This PR is completed, but it is based on the recent change in PR #222, which hasn't yet been merged. |
Why not use |
PR #222 has been merged so a rebase here should get this build working. |
Signed-off-by: Nuttawut Kongsuwan <win@finema.co>
ef039b0
to
09030c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Only thing is that test time increases significantly, I suppose there is now some overlap in this test and the multisig.test.ts file that can be addressed later.
Signed-off-by: Nuttawut Kongsuwan <win@finema.co>
Add an integration test for multi-signature delegated issuance of QVI, LE, and ECR vLEI credentials:
[Edit 18 Feb]: the three problems below seem to have been resolved.
Currently, there are two problems, one major and one minor:
client.registries().list()
. This is related to the issues in Signify-TS and KERIA, Intermittent KERIA Internal Server Errors (HTTP 500) when listing registries. keria#147, Transient error with usingclient.registries().list(name)
keria#177, and add test triggering credential revocation crash #202.