Issue-82-Inconsistencies-with-DOC__ROOT #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajuszczyk
changed the title
ajuszczyk
changed the title
|
Hi @ajuszczyk - thanks for the PR. Because this is a public repo, we need to log information about the changes for future users/maintainers. Please could you like this to the corresponding issue and provide a description detailing what the problem was and how your PR fixes it? Thank you and thanks again for the PR |
|
I'm afraid I don't have pesrission to link this PR to the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for $issue82.
The DOC__ROOT const is supposed to be set with a trailing forward slash but in at least one of its use cases, we concatenate with a string that leads with a forward slash, causing a double forward slash in the path.
It appears that Apache will handle this gracefully but NginX does not and will fail to find the included file.
Suggested fix is to remove any forward slashes at the start of strings concatenated with the DOC__ROOT constant.
The fix does as sugessted, removes any extra forward slashes.