[MSE SourceBuffer] Reset extra memory cost inside removedFromMediaSou… #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce() This allows SourceBuffer that was removed from media source to report memory that is actually in use. Otherwise it reports last value even if memory was relased already.
eocanha
added
the
upstream
|
Submitted the patch upstream for review as https://bugs.webkit.org/show_bug.cgi?id=267350 / WebKit/WebKit#22602. |
webkit-commit-queue
pushed a commit
to eocanha/WebKit
that referenced
this pull request
Jan 11, 2024
https://bugs.webkit.org/show_bug.cgi?id=267350 Reviewed by Xabier Rodriguez-Calvar. When the SourceBuffer is removed from a MediaSource, its TrackBuffers are cleared (and so is its data, which can take a good amount of memory), but the SourceBuffer still accounts for the cost of its old data, as m_extraMemoryCost isn't reset to zero. See: WebPlatformForEmbedded/WPEWebKit#1264 This patch resets m_extraMemoryCost when the SourceBuffer is removed. Original author: Andrzej Surdej <Andrzej_Surdej@comcast.com> * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::removedFromMediaSource): Reset m_extraMemoryCost. Canonical link: https://commits.webkit.org/272908@main
eocanha
added a commit
that referenced
this pull request
Jan 11, 2024
https://bugs.webkit.org/show_bug.cgi?id=267350 Reviewed by Xabier Rodriguez-Calvar. When the SourceBuffer is removed from a MediaSource, its TrackBuffers are cleared (and so is its data, which can take a good amount of memory), but the SourceBuffer still accounts for the cost of its old data, as m_extraMemoryCost isn't reset to zero. See: #1264 This patch resets m_extraMemoryCost when the SourceBuffer is removed. Original author: Andrzej Surdej <Andrzej_Surdej@comcast.com> * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::removedFromMediaSource): Reset m_extraMemoryCost. Canonical link: https://commits.webkit.org/272908@main
eocanha
added a commit
that referenced
this pull request
Jan 11, 2024
https://bugs.webkit.org/show_bug.cgi?id=267350 Reviewed by Xabier Rodriguez-Calvar. When the SourceBuffer is removed from a MediaSource, its TrackBuffers are cleared (and so is its data, which can take a good amount of memory), but the SourceBuffer still accounts for the cost of its old data, as m_extraMemoryCost isn't reset to zero. See: #1264 This patch resets m_extraMemoryCost when the SourceBuffer is removed. Original author: Andrzej Surdej <Andrzej_Surdej@comcast.com> * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::removedFromMediaSource): Reset m_extraMemoryCost. Canonical link: https://commits.webkit.org/272908@main
|
Patch landed upstream as WebKit/WebKit@4fa545a and packported to wpe-2.38 as da14ef5 and to wpe-2.42 as 8472a26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rce()
This allows SourceBuffer that was removed from media source to report memory that is actually in use. Otherwise it reports last value even if memory was relased already.
I think m_reportedExtraMemoryCost doesn't need to be reset as memory can not grow after removing SourceBuffer from media source. There is no way to reattach and data are not accepted also.
The same we did in 2.28 34e8375