Speech recognition #53

Haseenamol · 2016-05-04T12:40:38Z

SpeechRecogntition Work-in progress version for review:
Following are the status: Recognition start/stop/abort/events are implemented
Pending: Attributes lang, maxAlternatives, serviceURI, Grammar correction, Match string identification, speech training with more words and log message to WebKit log formats

…WebKitForWayland into speech-recognition To rebase to master

zdobersek · 2016-08-01T07:10:23Z

The base work looks fine. New source files do need license headers though.

zdobersek · 2016-08-01T07:11:05Z

Source/WebCore/Modules/speech/SpeechGrammar.h

+#if  ENABLE(SPEECH_RECOGNITION)
+
+#include "URL.h"
+#include "wtf/RefCounted.h"


WTF headers are usually included via angle brackets: <wtf/RefCounted.h>

zdobersek · 2016-08-01T07:11:41Z

Source/cmake/FindSphinx.cmake

+endif ()
+
+if (SPHINX_FOUND)
+    if (NOT SPHNIX_FIND_QUIETLY)


SPHNIX -> SPHINX, same for the following two lines.

Haseenamol · 2016-08-01T08:08:00Z

Thanks Zan for the comments.
I will check and correct your comments

charlie-ht · 2017-12-21T10:58:11Z

@Haseenamol Is this still on your todo list? Doing some cleaning of old PRs :)

Haseenamol · 2017-12-22T04:08:57Z

This was created long back and now there is lot of changes in the master. So I think, we can close the pull request for the time being and create new once we resume work on this

https://bugs.webkit.org/show_bug.cgi?id=258794 Reviewed by Youenn Fablet. The current WebRTC HEVC is using generic packetization instead of RFC 7789 Packetization. So this is about implementing the RFC 7798 Packetization. Fix HEVC depacketizer issues. (#185) Enalbing low latency mode for RTC (#169) Enable HEVC support. (#165) Fix out-of-bounds write in H265VpsSpsPpsTracker (#163) Apply fix bitstream logic to RtpVideoStreamReceiver2 (#142) Add missing CODEC_H265 switch case (#136) Add HEVC support for iOS/Android (#68) H265 packetization_mode setting fix (#53) Add H.265 QP parsing logic (#47) This patch is extracted from following Open WebRTC Toolkit code changes: <open-webrtc-toolkit/owt-deps-webrtc#185> <open-webrtc-toolkit/owt-deps-webrtc#169> <open-webrtc-toolkit/owt-deps-webrtc#165> <open-webrtc-toolkit/owt-deps-webrtc#163> <open-webrtc-toolkit/owt-deps-webrtc#142> <open-webrtc-toolkit/owt-deps-webrtc#136> <open-webrtc-toolkit/owt-deps-webrtc#68> <open-webrtc-toolkit/owt-deps-webrtc#53> <open-webrtc-toolkit/owt-deps-webrtc#47> co-authoured by: taste1981 <jianlin.qiu@intel.com> jianjunz <jianjun.zhu@intel.com> Cyril Lashkevich <notorca@gmail.com> Piasy <xz4215@gmail.com> ShiJinCheng <874042641@qq.com> Andreas Unterhuber <andreas.unterhuber@keepinmind.info> dong-heun <63987238+dong-heun@users.noreply.github.com> * Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video/video_codec_type.h: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_codec.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_codec.h: (webrtc::VideoCodecH265::operator!= const): * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_decoder_software_fallback_wrapper.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_encoder.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/video_encoder.h: * Source/ThirdParty/libwebrtc/Source/webrtc/call/rtp_payload_params.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_common.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_common.h: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_pps_parser.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_pps_parser.h: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_sps_parser.h: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_vps_parser.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_vps_parser.h: * Source/ThirdParty/libwebrtc/Source/webrtc/logging/rtc_event_log/rtc_event_log_parser.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/media/base/media_constants.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/media/base/media_constants.h: * Source/ThirdParty/libwebrtc/Source/webrtc/media/engine/internal_decoder_factory.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/create_video_rtp_depacketizer.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h265.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h265.h: (webrtc::RtpPacketizerH265::PacketUnit::PacketUnit): (webrtc::VideoRtpDepacketizerH265::~VideoRtpDepacketizerH265): Deleted. * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_video_header.h: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/h265/include/h265_globals.h: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/encoded_frame.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h265_vps_sps_pps_tracker.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h265_vps_sps_pps_tracker.h: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/include/video_codec_interface.h: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/packet_buffer.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/experiments/min_video_bitrate_experiment.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.h: * Source/ThirdParty/libwebrtc/Source/webrtc/test/scenario/video_stream.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/test/video_codec_settings.h: (webrtc::test::CodecSettings): * Source/ThirdParty/libwebrtc/Source/webrtc/video/config/video_encoder_config.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/video/config/video_encoder_config.h: * Source/ThirdParty/libwebrtc/Source/webrtc/video/encoder_overshoot_detector.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/video/rtp_video_stream_receiver2.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/video/rtp_video_stream_receiver2.h: * Source/ThirdParty/libwebrtc/Source/webrtc/video/send_statistics_proxy.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/video/video_stream_encoder.cc: * Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/267677@main

haseenamol@tataelxsi.co.in added 25 commits April 7, 2016 10:45

Speech Recognition Wrapper Files added

167b269

Speech Recognition Wrapper Files added

e5913bb

compilation error corrected

e12eb69

Start/Stop Sequence added

73a25ca

SpeechRecognition Events handling added

964597d

vtable undefined issue fix added

2d86a6c

Speech Recognition intrim, continuous support added

17360bf

speech abort issue corrected

807b776

speech abort issue corrected

d63ef7a

SpeechRecognition constructor support added in idl

8fb5767

Speech Recognition Wrapper Files added

ef27fe6

Speech Recognition Wrapper Files added

e7af0e4

compilation error corrected

90b0735

Start/Stop Sequence added

0be6bba

SpeechRecognition Events handling added

e5a2ec6

vtable undefined issue fix added

36a67c1

Speech Recognition intrim, continuous support added

d587818

speech abort issue corrected

33d263e

speech abort issue corrected

beb8054

SpeechRecognition constructor support added in idl

840b83b

unwanted files removed

090ba91

Merge branch 'speech-recognition' of https://github.com/Metrological/…

8c97a88

…WebKitForWayland into speech-recognition To rebase to master

removed unwanted files

35b78fe

1. printf moved to Webkit LOG, 2. device open error event added

e66062b

Pocketsphinx optimzation flag + Confidence Support added

dac8121

albertd assigned zdobersek May 20, 2016

philn force-pushed the master branch 2 times, most recently from b4a4f67 to 3f4ede2 Compare June 17, 2016 13:48

zdobersek reviewed Aug 1, 2016
View reviewed changes

Source/cmake/FindSphinx.cmake

endif ()

if (SPHINX_FOUND)

if (NOT SPHNIX_FIND_QUIETLY)

Copy link

zdobersek Aug 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPHNIX -> SPHINX, same for the following two lines.

Haseenamol closed this Dec 22, 2017

pkumbh631 mentioned this pull request Apr 5, 2021

WPEWebProcess crash in createResolve #704

Closed

asurdej-comcast mentioned this pull request Aug 2, 2023

Wpe-2.38 Deadlock in WebKitMediaSrc (PrimeVideo) #1135

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Speech recognition #53

Speech recognition #53

Haseenamol commented May 4, 2016

zdobersek commented Aug 1, 2016

zdobersek Aug 1, 2016

zdobersek Aug 1, 2016

Haseenamol commented Aug 1, 2016

charlie-ht commented Dec 21, 2017

Haseenamol commented Dec 22, 2017

Speech recognition #53

Speech recognition #53

Conversation

Haseenamol commented May 4, 2016

zdobersek commented Aug 1, 2016

zdobersek Aug 1, 2016

Choose a reason for hiding this comment

zdobersek Aug 1, 2016

Choose a reason for hiding this comment

Haseenamol commented Aug 1, 2016

charlie-ht commented Dec 21, 2017

Haseenamol commented Dec 22, 2017