Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderer-backend-egl.c: check interface pointer before usage #30

Merged
merged 1 commit into from Oct 23, 2018
Merged

renderer-backend-egl.c: check interface pointer before usage #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/renderer-backend-egl.c
View file
Open in desktop
Expand Up @@ -39,6 +39,9 @@ wpe_renderer_backend_egl_create(int host_fd)
return 0;

backend->interface = wpe_load_object("_wpe_renderer_backend_egl_interface");
if (!backend->interface)
return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am somewhat surprised that return NULL; was not being used in this function before, which IMHO would have been more correct 🙃

Probably it's a good moment to start using NULL for early returns in this function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aperezdc Yes I think returning NULL would make sense. I'm not that much familiar with the project and was just following the existing style.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this with return 0; in this PR (to keep things consistent) and then if we want to change the code to use NULL make a follow-up PR with that change.

If @zdobersek does not comment in the next couple of days, I say let's merge this PR as-is 😉


backend->interface_data = backend->interface->create(host_fd);

return backend;
Expand Down Expand Up @@ -70,6 +73,9 @@ wpe_renderer_backend_egl_target_create(int host_fd)
return 0;

target->interface = wpe_load_object("_wpe_renderer_backend_egl_target_interface");
if (!target->interface)
return 0;

target->interface_data = target->interface->create(target, host_fd);

return target;
Expand Down Expand Up @@ -140,6 +146,9 @@ wpe_renderer_backend_egl_offscreen_target_create()
return 0;

target->interface = wpe_load_object("_wpe_renderer_backend_egl_offscreen_target_interface");
if (!target->interface)
return 0;

target->interface_data = target->interface->create();

return target;
Expand Down