Popup menus #57
Popup menus #57
Conversation
Moving the input handling to a separate object that wpe_view_backend contains allows other objects to also be treated as input objects.
The platform backend interface allows WebKit core to call into platform specific backend API, which will eventually be used to implement popup menu support.
Adds support for allocating popup menus from then platform backend, allocating buffers, and attaching them to the popup menu.
There was a problem hiding this comment.
What is the advantage of doing this, and funneling things through libwpe?
The WebKitWebView:show-option-menu can be used directly by an embedding application to implement popups in any way it may need already. For example this is done in Igalia/cog#190 using Cairo to paint the menus—but it could have used anything else.
Unless there is some use case that this solves and cannot be taken care of handling the show-option-menu signal, I would rather not merge this 🤔
|
I think this is unnecessary and I just forgot to close it. Thanks :) |
|
|
||
| struct wpe_view_platform_interface { | ||
| bool (*create_popup)(void*, struct wpe_popup*, int32_t, int32_t, int32_t, int32_t, int32_t, int32_t); | ||
| bool (*alloc_buffer)(void*, struct wpe_buffer*, uint32_t, uint32_t, uint32_t); | ||
|
|
||
| void (*_wpe_reserved0)(void); | ||
| void (*_wpe_reserved1)(void); |
There was a problem hiding this comment.
You need to remove the last two bytes of padding here to avoid breaking ABI.
| struct wpe_popup_interface { | ||
| void (*destroy)(void*); | ||
| void (*attach_buffer)(void*, void*); | ||
| void (*get_info)(void*, struct wpe_popup_info*); |
There was a problem hiding this comment.
Similarly, you'll want to add several padding bytes here so that you can expand this struct in the future. I guess four bytes is standard for libwpe.
|
|
||
| struct wpe_buffer_interface { | ||
| void (*destroy)(void*); | ||
| void (*get_info)(void*, struct wpe_buffer_info* info); |
|
Not that it matters anymore. :) |
Adds support for WebKit to allocate popup menus.