Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpe dependency and packaging improvements #2

Merged
merged 3 commits into from
Oct 24, 2015
Merged

wpe dependency and packaging improvements #2

merged 3 commits into from
Oct 24, 2015

Conversation

armcc
Copy link
Contributor

@armcc armcc commented Oct 24, 2015

No description provided.

Plus other misc recipe cleanup.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
albertd added a commit that referenced this pull request Oct 24, 2015
wpe dependency and packaging improvements
@albertd albertd merged commit 67f9d5a into WebPlatformForEmbedded:master Oct 24, 2015
armcc added a commit to armcc/meta-metrological that referenced this pull request Nov 5, 2016
Fix for MIPS ctiVMThrowTrampoline() relocation overflow build error:

 | linking ../lib/libQt5WebKit.so.5.4.1
 | /.../tmp/work/mips32el-rdk-linux/qtwebkit/5.4.1+metro+gitAUTOINC+dcacbc49cc-r0/build/Source/JavaScriptCore//libJavaScriptCore.a(/.../tmp/work/mips32el-rdk-linux/qtwebkit/5.4.1+metro+gitAUTOINC+dcacbc49cc-r0/build/Source/JavaScriptCore//.obj/jit/JITStubs.o):JITStubs.cpp:function ctiVMThrowTrampoline: error: relocation overflow
 | collect2: error: ld returned 1 exit status
 | make[2]: *** [../lib/libQt5WebKit.so.5.4.1] Error 1

Fix tested by confirming that the Octane 2.0 JavaScript benchmark
runs without errors with breakpoints in ctiVMThrowTrampoline() used
to confirm test coverage.

  Breakpoint 1, 0x0069a7c0 in ctiVMThrowTrampoline ()
  (gdb) bt
  #0  0x0069a7c0 in ctiVMThrowTrampoline ()
  WebPlatformForEmbedded#1  0x0069a7b8 in ctiTrampoline ()
  WebPlatformForEmbedded#2  0x0064ba84 in JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) ()
  WebPlatformForEmbedded#3  0x00799abc in JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) ()
  WebPlatformForEmbedded#4  0x0042e2dc in jscmain(int, char**) ()
  WebPlatformForEmbedded#5  0x0042fa00 in main ()

The offending code was remove from Webkit in 2013, so the only
upstream for this patch is qtwebkit.

  https://github.com/Metrological/qtwebkit/blob/qt5.4/Source/JavaScriptCore/jit/JITStubs.cpp#L592
  WebPlatformForEmbedded/WPEWebKit@bdfcf6a#diff-2b4225b6f02ff83d4a12f7a00c3c4338L112

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
@kraj kraj mentioned this pull request Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants