Skip to content
This repository has been archived by the owner on Oct 23, 2019. It is now read-only.

Please include license in package.json #25

Closed
platinumazure opened this issue Aug 1, 2016 · 3 comments
Closed

Please include license in package.json #25

platinumazure opened this issue Aug 1, 2016 · 3 comments

Comments

@platinumazure
Copy link
Contributor

The ESLint project uses file-entry-cache which uses flat-cache which uses circular-json. ESLint does a license check of direct and indirect dependencies to be sure that we aren't introducing risk of legal liability to our consumers.

This project seems to use the MIT license, which is a great license for us. We just need the license information to be included in package.json for our check. (A side benefit of doing this is that the npmjs.com page for your package will also show the license information in the sidebar.)

I will submit a PR to fix this shortly. Thanks in advance for your consideration!

@platinumazure
Copy link
Contributor Author

Oh, regarding impact: We're working on pinning our intervening dependency packages to get around this so we can do our release today. However, if you could merge the linked PR and do a patch release within the next couple of days, that would be ideal as it would allow us to revert our pinned dependencies.

Thanks so much for your help!

@WebReflection
Copy link
Owner

It's published with a license as 0.3.1, thanks for the PR

@platinumazure
Copy link
Contributor Author

Thanks so much @WebReflection for your quick response!

royriojas pushed a commit to jaredwray/flat-cache that referenced this issue Aug 2, 2016
As mentioned in WebReflection/circular-json#25 `circular-json` wan't rightly implementing the license field.

Latest version bump changed only that bit so that ESLint should now be happy.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants