Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure observed/boolean attributes passes through the prototype #70

Closed
WebReflection opened this issue Nov 3, 2020 · 0 comments
Closed

Ensure observed/boolean attributes passes through the prototype #70

WebReflection opened this issue Nov 3, 2020 · 0 comments

Comments

@WebReflection
Copy link
Owner

WebReflection commented Nov 3, 2020 •
edited
Loading

Currently, if a generic-element.thing = value happens before generic-element is defined, and thing happens to be either an observed, or boolean, attribute, the get/set prototype dance is never triggered.

Please fix this ASAP right before the created call is invoked.

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/issues/844#note_441123448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WebReflection