New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Indian holidays #3
Add Indian holidays #3
Conversation
latest version uses modules instead, where any date can be actually a function that will receive the meant year to deal with ... do you mid updating this PR reflecting that change ? You can find an Italian easter example in here. Or at least it could export a module so for the time being, your country has some date to show 😉 Thanks a lot for your initial PR anyway !!! |
Apologies @notlmn but too many things changed in the meanwhile (early state, I want to get this right). Please have a look at latest state and see the Feel free to check the |
Hey, I am working on it. I also did a rebase locally. This PR should not affect most things considering the changes are in a separate file. I waited because I was working on how to find dates for holidays, because holidays in India literally depend the position of Sun and Moon. |
wow! looking forward to the updated PR then 🎉 |
P.S. holy sh.... https://www.officeholidays.com/countries/india/index.php 😱 Please remember to use |
Yeah, holy whatever. As I told you already more than 90% of holidays are dynamic (most literally depend on position of Sun and Moon, and most of them regional). The one's already statically provided are the only national holidays. I'm thankful for your patience, because this PR might take some more time because I'm in an overcrowded train that might take another 2 hours to reach it's destination. |
I didn't mean to rush you at all ... take all the time you want but I'm sure already it'd be a fantastic contribution (in general, not only for this project). |
bc529c6
to
522609b
Compare
@WebReflection I've rebased and added all the static holidays for now. It looks like the dynamic holidays might take some more time (I'm planning to work on an Indian calendar that might help solve dynamic dates). You can merge this for now, I'll make a PR later to remaining dynamic holidays when I'm done. |
More than 90% of holidays in India are dynamic. This PR adds only fixed holidays for now. Need to wait till #2 gets merged to add add dynamic holidays.