added support for boolean attributes

WebReflection · Feb 11, 2021 · f1e595d · f1e595d
1 parent 7310a9e
commit f1e595d
Show file tree

Hide file tree

Showing 9 changed files with 43 additions and 12 deletions.
diff --git a/cjs/index.js b/cjs/index.js
@@ -37,6 +37,14 @@ const attribute = (node, name) => {
 };
 exports.attribute = attribute;
 
+const boolean = (node, key) => value => {
+  if (value)
+    node.setAttribute(key, '');
+  else
+    node.removeAttribute(key);
+};
+exports.boolean = boolean;
+
 const data = ({dataset}) => values => {
   for (const key in values) {
     const value = values[key];

diff --git a/es.js b/es.js
diff --git a/esm/index.js b/esm/index.js
@@ -34,6 +34,13 @@ export const attribute = (node, name) => {
   };
 };
 
+export const boolean = (node, key) => value => {
+  if (value)
+    node.setAttribute(key, '');
+  else
+    node.removeAttribute(key);
+};
+
 export const data = ({dataset}) => values => {
   for (const key in values) {
     const value = values[key];

diff --git a/index.js b/index.js
@@ -36,6 +36,12 @@ var uhtmlHandlers = (function (exports) {
       }
     };
   };
+
+  var _boolean = function _boolean(node, key) {
+    return function (value) {
+      if (value) node.setAttribute(key, '');else node.removeAttribute(key);
+    };
+  };
   var data = function data(_ref) {
     var dataset = _ref.dataset;
     return function (values) {
@@ -80,6 +86,7 @@ var uhtmlHandlers = (function (exports) {
 
   exports.aria = aria;
   exports.attribute = attribute;
+  exports.boolean = _boolean;
   exports.data = data;
   exports.event = event;
   exports.ref = ref;

diff --git a/min.js b/min.js
diff --git a/package.json b/package.json
@@ -20,17 +20,17 @@
   "author": "Andrea Giammarchi",
   "license": "ISC",
   "devDependencies": {
-    "@babel/core": "^7.11.4",
-    "@babel/preset-env": "^7.11.0",
-    "@rollup/plugin-babel": "^5.2.0",
-    "@rollup/plugin-node-resolve": "^9.0.0",
-    "ascjs": "^4.0.1",
+    "@babel/core": "^7.12.13",
+    "@babel/preset-env": "^7.12.13",
+    "@rollup/plugin-babel": "^5.2.3",
+    "@rollup/plugin-node-resolve": "^11.1.1",
+    "ascjs": "^5.0.0",
     "coveralls": "^3.1.0",
-    "linkedom": "^0.1.39",
+    "linkedom": "^0.4.12",
     "nyc": "^15.1.0",
-    "rollup": "^2.26.5",
-    "rollup-plugin-terser": "^7.0.0",
-    "terser": "^5.2.1"
+    "rollup": "^2.38.5",
+    "rollup-plugin-terser": "^7.0.2",
+    "terser": "^5.6.0-beta"
   },
   "module": "./esm/index.js",
   "type": "module",

diff --git a/rollup/babel.config.js b/rollup/babel.config.js
@@ -11,6 +11,7 @@ export default {
     })
   ],
   output: {
+    esModule: false,
     exports: 'named',
     file: './index.js',
     format: 'iife',

diff --git a/rollup/es.config.js b/rollup/es.config.js
@@ -8,6 +8,7 @@ export default {
     terser()
   ],
   output: {
+    esModule: false,
     exports: 'named',
     file: './es.js',
     format: 'iife',

diff --git a/test/index.js b/test/index.js
@@ -4,7 +4,7 @@ global.document = document;
 if (!('onclick' in HTMLElement.prototype))
   HTMLElement.prototype.onclick = function () {};
 
-const {aria, attribute, data, event, ref, setter, text} = require('../cjs');
+const {aria, attribute, boolean, data, event, ref, setter, text} = require('../cjs');
 
 const div = document.createElement('div');
 
@@ -61,3 +61,10 @@ textfy('value');
 console.assert(div.textContent === 'value', 'text(value)');
 textfy(void 0);
 console.assert(div.textContent === '', 'text(void 0)');
+
+const booleanify = boolean(div, 'boolean');
+console.assert(!div.hasAttribute('boolean'), 'no boolean');
+booleanify(1);
+console.assert(div.hasAttribute('boolean'), 'yes boolean');
+booleanify(0);
+console.assert(!div.hasAttribute('boolean'), 'no boolean again');